Skip to content

Fix kafka plugin sometimes trace doesn't show span layer#5264

Merged
wu-sheng merged 4 commits intoapache:masterfrom
J-Cod3r:kafka-plugin-bugfix
Aug 8, 2020
Merged

Fix kafka plugin sometimes trace doesn't show span layer#5264
wu-sheng merged 4 commits intoapache:masterfrom
J-Cod3r:kafka-plugin-bugfix

Conversation

@J-Cod3r
Copy link
Contributor

@J-Cod3r J-Cod3r commented Aug 7, 2020

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bug fix
  • New feature provided
  • Improve performance

Bug fix

  • Which version of SkyWalking, OS and JRE?
    SkyWalking 7.0, Redhat 7.6, jre 11
  • Bug description.
    kafka plugin sometimes trace doesn't show span layer
    kafka

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is layer important for a callback?

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #5264 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5264      +/-   ##
============================================
- Coverage     53.43%   53.08%   -0.36%     
+ Complexity     3172     3167       -5     
============================================
  Files           816      820       +4     
  Lines         20451    20521      +70     
  Branches       1967     1974       +7     
============================================
- Hits          10929    10893      -36     
- Misses         8639     8746     +107     
+ Partials        883      882       -1     
Impacted Files Coverage Δ Complexity Δ
...s/manual/database/DatabaseStatementDispatcher.java 10.00% <0.00%> (-90.00%) 1.00% <0.00%> (-1.00%)
...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java 50.00% <0.00%> (-50.00%) 1.00% <0.00%> (-2.00%)
...skywalking/oap/server/core/analysis/topn/TopN.java 0.00% <0.00%> (-33.34%) 0.00% <0.00%> (-1.00%)
...er/core/analysis/data/LimitedSizeBufferedData.java 15.38% <0.00%> (-23.08%) 1.00% <0.00%> (-1.00%)
...ng/oap/server/core/analysis/worker/TopNWorker.java 43.75% <0.00%> (-12.50%) 4.00% <0.00%> (-1.00%)
...rver/core/analysis/worker/TopNStreamProcessor.java 65.38% <0.00%> (-11.54%) 4.00% <0.00%> (-1.00%)
...nalysis/manual/database/TopNDatabaseStatement.java 4.16% <0.00%> (-8.34%) 0.00% <0.00%> (-2.00%)
...rary/client/elasticsearch/ElasticSearchClient.java 54.34% <0.00%> (-4.35%) 25.00% <0.00%> (-1.00%)
...e/parser/listener/MultiScopesAnalysisListener.java 68.33% <0.00%> (-2.23%) 24.00% <0.00%> (ø%)
...ng/oap/server/core/alarm/provider/RunningRule.java 51.85% <0.00%> (-0.53%) 10.00% <0.00%> (ø%)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b441f0...12498d9. Read the comment docs.

@J-Cod3r
Copy link
Contributor Author

J-Cod3r commented Aug 7, 2020

Why is layer important for a callback?

Not important, but is it unfriendly to display "Unknown"?

@wu-sheng wu-sheng added this to the 8.2.0 milestone Aug 7, 2020
@wu-sheng wu-sheng added agent Language agent related. plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels Aug 7, 2020
wu-sheng
wu-sheng previously approved these changes Aug 7, 2020
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, the layer is sensitive for Entry/Exit span only. This is harmless, but at the same time, also meaningless.

@wu-sheng wu-sheng added the chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. label Aug 7, 2020
@wu-sheng
Copy link
Member

wu-sheng commented Aug 7, 2020

With this kind of changes, it affects the plugin test. Please fix them.

@wu-sheng wu-sheng removed this from the 8.2.0 milestone Aug 7, 2020
@wu-sheng wu-sheng added this to the 8.2.0 milestone Aug 8, 2020
@wu-sheng wu-sheng merged commit 9b6a4ed into apache:master Aug 8, 2020
@J-Cod3r J-Cod3r deleted the kafka-plugin-bugfix branch August 8, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Language agent related. chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants