Fix kafka plugin sometimes trace doesn't show span layer#5264
Merged
wu-sheng merged 4 commits intoapache:masterfrom Aug 8, 2020
Merged
Fix kafka plugin sometimes trace doesn't show span layer#5264wu-sheng merged 4 commits intoapache:masterfrom
wu-sheng merged 4 commits intoapache:masterfrom
Conversation
wu-sheng
reviewed
Aug 7, 2020
Member
wu-sheng
left a comment
There was a problem hiding this comment.
Why is layer important for a callback?
Codecov Report
@@ Coverage Diff @@
## master #5264 +/- ##
============================================
- Coverage 53.43% 53.08% -0.36%
+ Complexity 3172 3167 -5
============================================
Files 816 820 +4
Lines 20451 20521 +70
Branches 1967 1974 +7
============================================
- Hits 10929 10893 -36
- Misses 8639 8746 +107
+ Partials 883 882 -1 Continue to review full report at Codecov.
|
Contributor
Author
Not important, but is it unfriendly to display "Unknown"? |
wu-sheng
previously approved these changes
Aug 7, 2020
Member
wu-sheng
left a comment
There was a problem hiding this comment.
Usually, the layer is sensitive for Entry/Exit span only. This is harmless, but at the same time, also meaningless.
Member
|
With this kind of changes, it affects the plugin test. Please fix them. |
wu-sheng
approved these changes
Aug 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Bug fix
SkyWalking 7.0, Redhat 7.6, jre 11
kafka plugin sometimes trace doesn't show span layer