Skip to content

bugfix: Fix CLR Heap Memory metrics aggregation configuration error in ui-initialized-templates.#5346

Merged
wu-sheng merged 1 commit intoapache:masterfrom
snakorse:master
Aug 18, 2020
Merged

bugfix: Fix CLR Heap Memory metrics aggregation configuration error in ui-initialized-templates.#5346
wu-sheng merged 1 commit intoapache:masterfrom
snakorse:master

Conversation

@snakorse
Copy link
Contributor

@snakorse snakorse commented Aug 18, 2020

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bug fix
  • New feature provided
  • Improve performance

Bug fix

  • Bug description.
    The CLR Heap Memory (MB) metrics in Dashboard->Instance tab titled with MB unit, but actually the value shows in byte unit.

  • How to fix?
    Correct the configuration in ui-initialized-templates.yml file.

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #5346 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5346      +/-   ##
============================================
- Coverage     53.19%   53.13%   -0.07%     
+ Complexity     3212     3208       -4     
============================================
  Files           830      830              
  Lines         20850    20850              
  Branches       2023     2023              
============================================
- Hits          11092    11079      -13     
- Misses         8851     8863      +12     
- Partials        907      908       +1     
Impacted Files Coverage Δ Complexity Δ
...er/core/server/auth/AuthenticationInterceptor.java 0.00% <0.00%> (-61.54%) 0.00% <0.00%> (-3.00%)
...er/sharing/server/ReceiverGRPCHandlerRegister.java 30.76% <0.00%> (-46.16%) 2.00% <0.00%> (-3.00%)
...ap/server/core/server/GRPCHandlerRegisterImpl.java 62.50% <0.00%> (-25.00%) 2.00% <0.00%> (-1.00%)
.../server/storage/plugin/jdbc/h2/dao/H2BatchDAO.java 64.10% <0.00%> (-10.26%) 5.00% <0.00%> (ø%)
...ing/oap/server/library/server/grpc/GRPCServer.java 55.93% <0.00%> (-5.09%) 6.00% <0.00%> (-1.00%)
...in/elasticsearch7/client/ElasticSearch7Client.java 57.77% <0.00%> (-4.45%) 17.00% <0.00%> (-1.00%)
...er/sharing/server/SharingServerModuleProvider.java 43.47% <0.00%> (-1.45%) 8.00% <0.00%> (ø%)
...meter/function/AvgHistogramPercentileFunction.java 62.50% <0.00%> (+0.73%) 21.00% <0.00%> (+1.00%)
...ing/apm/agent/core/logging/core/PatternLogger.java 59.45% <0.00%> (+2.70%) 20.00% <0.00%> (+2.00%)
...kywalking/apm/agent/core/jvm/JVMMetricsSender.java 88.23% <0.00%> (+5.88%) 11.00% <0.00%> (ø%)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da4015...5469fb1. Read the comment docs.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@wu-sheng wu-sheng added this to the 8.2.0 milestone Aug 18, 2020
@wu-sheng wu-sheng added the UI UI and front end related. label Aug 18, 2020
@wu-sheng wu-sheng merged commit 4e60690 into apache:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI UI and front end related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants