Skip to content

support Slack alarm hooks#5364

Merged
wu-sheng merged 8 commits intomasterfrom
slack_alarm
Aug 22, 2020
Merged

support Slack alarm hooks#5364
wu-sheng merged 8 commits intomasterfrom
slack_alarm

Conversation

@JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented Aug 21, 2020

Please answer these questions before submitting a pull request


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

@JaredTan95 JaredTan95 requested review from hanahmily, kezhenxu94 and wu-sheng and removed request for kezhenxu94 August 21, 2020 06:33
@JaredTan95 JaredTan95 added this to the 8.2.0 milestone Aug 21, 2020
@JaredTan95 JaredTan95 added backend OAP backend related. enhancement Enhancement on performance or codes labels Aug 21, 2020
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #5364 into master will decrease coverage by 0.11%.
The diff coverage is 29.41%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5364      +/-   ##
============================================
- Coverage     53.24%   53.12%   -0.12%     
+ Complexity     3224     3218       -6     
============================================
  Files           827      831       +4     
  Lines         20875    20943      +68     
  Branches       2029     2032       +3     
============================================
+ Hits          11115    11127      +12     
- Misses         8850     8907      +57     
+ Partials        910      909       -1     
Impacted Files Coverage Δ Complexity Δ
.../server/core/alarm/provider/AlarmRulesWatcher.java 64.70% <0.00%> (-1.97%) 6.00 <0.00> (ø)
...ywalking/oap/server/core/alarm/provider/Rules.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
...ap/server/core/alarm/provider/WebhookCallback.java 28.57% <16.66%> (ø) 2.00 <1.00> (ø)
...r/core/alarm/provider/slack/SlackhookCallback.java 23.25% <23.25%> (ø) 2.00 <2.00> (?)
...ng/oap/server/core/alarm/provider/RulesReader.java 53.62% <47.05%> (-5.31%) 3.00 <0.00> (ø)
.../oap/server/core/alarm/provider/NotifyHandler.java 97.91% <100.00%> (+0.02%) 17.00 <0.00> (ø)
.../core/logging/core/coverts/ThrowableConverter.java 18.18% <0.00%> (-63.64%) 2.00% <0.00%> (-2.00%)
...apm/agent/core/remote/ServiceManagementClient.java 73.58% <0.00%> (-9.44%) 10.00% <0.00%> (-1.00%)
...king/apm/agent/core/remote/GRPCChannelManager.java 56.41% <0.00%> (-8.98%) 12.00% <0.00%> (-3.00%)
...kywalking/apm/agent/core/jvm/JVMMetricsSender.java 82.35% <0.00%> (-8.83%) 11.00% <0.00%> (-1.00%)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bfac1b...693e892. Read the comment docs.

@kezhenxu94 kezhenxu94 self-requested a review August 22, 2020 01:18
@kezhenxu94 kezhenxu94 dismissed their stale review August 22, 2020 01:19

Review comments are addressed

@kezhenxu94
Copy link
Member

Fix the failed checks (because of logger naming issue), and the PR looks good to me

@wu-sheng
Copy link
Member

@JaredTan95 Do you have a screenshot? I need one for twitter :)

@wu-sheng wu-sheng merged commit 3dfa40e into master Aug 22, 2020
@wu-sheng wu-sheng deleted the slack_alarm branch August 22, 2020 09:18
@JaredTan95
Copy link
Member Author

@JaredTan95 Do you have a screenshot? I need one for twitter :)

image

@wu-sheng
Copy link
Member

Will post on Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. enhancement Enhancement on performance or codes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forward the alarm message to slack

3 participants