Conversation
Codecov Report
@@ Coverage Diff @@
## master #5364 +/- ##
============================================
- Coverage 53.24% 53.12% -0.12%
+ Complexity 3224 3218 -6
============================================
Files 827 831 +4
Lines 20875 20943 +68
Branches 2029 2032 +3
============================================
+ Hits 11115 11127 +12
- Misses 8850 8907 +57
+ Partials 910 909 -1 Continue to review full report at Codecov.
|
kezhenxu94
previously requested changes
Aug 21, 2020
...m-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/skywalking/oap/server/core/alarm/provider/slack/SlackhookCallback.java
Outdated
Show resolved
Hide resolved
Member
|
Fix the failed checks (because of |
wu-sheng
reviewed
Aug 22, 2020
.../main/java/org/apache/skywalking/oap/server/core/alarm/provider/slack/SlackhookCallback.java
Outdated
Show resolved
Hide resolved
wu-sheng
reviewed
Aug 22, 2020
kezhenxu94
approved these changes
Aug 22, 2020
wu-sheng
approved these changes
Aug 22, 2020
Member
|
@JaredTan95 Do you have a screenshot? I need one for twitter :) |
Member
Author
|
Member
|
Will post on Monday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Please answer these questions before submitting a pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
closes Forward the alarm message to slack #5355
Bug fix
Bug description.
How to fix?
New feature or improvement