Merged
Conversation
kezhenxu94
requested changes
Sep 3, 2020
Member
kezhenxu94
left a comment
There was a problem hiding this comment.
For existing config names, we prefer to keep it as is for compatibility, your changes are breakages
Member
Author
|
the config name is submited by me recently. And 8.2.0 has not been released, i think i can fix it |
kezhenxu94
approved these changes
Sep 3, 2020
wu-sheng
approved these changes
Sep 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #5432 +/- ##
============================================
+ Coverage 52.25% 52.31% +0.06%
- Complexity 3301 3312 +11
============================================
Files 1567 1567
Lines 33609 33603 -6
Branches 3654 3658 +4
============================================
+ Hits 17561 17581 +20
+ Misses 15215 15188 -27
- Partials 833 834 +1 Continue to review full report at Codecov.
|
Member
|
I submitted a rerun. |
vcjmhg
pushed a commit
to vcjmhg/skywalking
that referenced
this pull request
Sep 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
fix doc