Skip to content

fix doc#5432

Merged
wu-sheng merged 2 commits intoapache:masterfrom
EvanLjp:fix_doc
Sep 3, 2020
Merged

fix doc#5432
wu-sheng merged 2 commits intoapache:masterfrom
EvanLjp:fix_doc

Conversation

@EvanLjp
Copy link
Copy Markdown
Member

@EvanLjp EvanLjp commented Sep 3, 2020

Please answer these questions before submitting a pull request

  • Why submit this pull request?
    fix doc

@kezhenxu94 kezhenxu94 added the documentation Provide documents related issue or pull request only. label Sep 3, 2020
@kezhenxu94 kezhenxu94 added this to the 8.2.0 milestone Sep 3, 2020
Copy link
Copy Markdown
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For existing config names, we prefer to keep it as is for compatibility, your changes are breakages

@kezhenxu94 kezhenxu94 closed this Sep 3, 2020
@kezhenxu94 kezhenxu94 added wontfix This will not be worked on and removed documentation Provide documents related issue or pull request only. labels Sep 3, 2020
@EvanLjp
Copy link
Copy Markdown
Member Author

EvanLjp commented Sep 3, 2020

the config name is submited by me recently. And 8.2.0 has not been released, i think i can fix it

@kezhenxu94 kezhenxu94 reopened this Sep 3, 2020
@kezhenxu94 kezhenxu94 added documentation Provide documents related issue or pull request only. and removed wontfix This will not be worked on labels Sep 3, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 3, 2020

Codecov Report

Merging #5432 into master will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5432      +/-   ##
============================================
+ Coverage     52.25%   52.31%   +0.06%     
- Complexity     3301     3312      +11     
============================================
  Files          1567     1567              
  Lines         33609    33603       -6     
  Branches       3654     3658       +4     
============================================
+ Hits          17561    17581      +20     
+ Misses        15215    15188      -27     
- Partials        833      834       +1     
Impacted Files Coverage Δ Complexity Δ
...gin/spring/annotations/SpringAnnotationConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...r/cluster/plugin/standalone/StandaloneManager.java 77.77% <0.00%> (-22.23%) 3.00% <0.00%> (-1.00%)
...core/analysis/manual/instance/InstanceTraffic.java 56.00% <0.00%> (-4.00%) 7.00% <0.00%> (ø%)
...ng/oap/server/core/alarm/provider/RunningRule.java 56.95% <0.00%> (-0.45%) 11.00% <0.00%> (ø%)
...apache/skywalking/apm/agent/core/util/IOUtils.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ache/skywalking/apm/agent/core/util/FileUtils.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...apm/agent/core/context/RuntimeContextSnapshot.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...m/agent/core/conf/RuntimeContextConfiguration.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...meter/function/AvgHistogramPercentileFunction.java 62.50% <0.00%> (+0.73%) 21.00% <0.00%> (+1.00%)
...csearch/query/ProfileThreadSnapshotQueryEsDAO.java 94.18% <0.00%> (+2.32%) 11.00% <0.00%> (+2.00%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9143f13...7af4ae8. Read the comment docs.

@wu-sheng
Copy link
Copy Markdown
Member

wu-sheng commented Sep 3, 2020

I submitted a rerun.

@wu-sheng wu-sheng merged commit 0e13268 into apache:master Sep 3, 2020
vcjmhg pushed a commit to vcjmhg/skywalking that referenced this pull request Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Provide documents related issue or pull request only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants