support build individual module by xbkaishui · Pull Request #5489 · apache/skywalking

xbkaishui · 2020-09-15T08:07:04Z

Please answer these questions before submitting a pull request

Why submit this pull request?
Bug fix
Related issues
resolved Support build individual module #5488

Bug fix

Bug description.
How to fix?
In submodule build, using the absolute path to find the check-style file

New feature or improvement

Describe the details and related test reports.

wu-sheng · 2020-09-15T08:26:40Z

This commend doesn't work locally.

xbkaishui · 2020-09-15T08:38:05Z

I test in my Mac, it works ok, can you show the details?

codecov · 2020-09-15T08:38:39Z

Codecov Report

Merging #5489 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #5489      +/-   ##
============================================
+ Coverage     52.10%   52.16%   +0.05%     
+ Complexity     3347     3321      -26     
============================================
  Files           898     1590     +692     
  Lines         22166    33887   +11721     
  Branches       2122     3694    +1572     
============================================
+ Hits          11550    17677    +6127     
- Misses         9687    15359    +5672     
+ Partials        929      851      -78

Impacted Files	Coverage Δ	Complexity Δ
...ing/oap/server/library/util/ProtoBufJsonUtils.java	`0.00% <0.00%> (-90.00%)`	`0.00% <0.00%> (-2.00%)`
...tworkalias/NetworkAddressAliasSetupDispatcher.java	`11.11% <0.00%> (-88.89%)`	`1.00% <0.00%> (-1.00%)`
...erver/receiver/envoy/MetricServiceGRPCHandler.java	`12.16% <0.00%> (-77.84%)`	`2.00% <0.00%> (ø%)`
...ler/v8/rest/ManagementServiceKeepAliveHandler.java	`32.00% <0.00%> (-64.00%)`	`2.00% <0.00%> (-1.00%)`
...rest/ManagementServiceReportPropertiesHandler.java	`27.58% <0.00%> (-62.07%)`	`2.00% <0.00%> (-2.00%)`
...lysis/manual/networkalias/NetworkAddressAlias.java	`2.43% <0.00%> (-56.10%)`	`0.00% <0.00%> (-5.00%)`
...p/server/core/source/NetworkAddressAliasSetup.java	`33.33% <0.00%> (-50.01%)`	`2.00% <0.00%> (-1.00%)`
...r/listener/NetworkAddressAliasMappingListener.java	`36.36% <0.00%> (-39.40%)`	`4.00% <0.00%> (-1.00%)`
...er/receiver/envoy/AccessLogServiceGRPCHandler.java	`20.75% <0.00%> (-37.15%)`	`2.00% <0.00%> (ø%)`
...skywalking/oap/server/core/alarm/AlarmMessage.java	`66.66% <0.00%> (-33.34%)`	`2.00% <0.00%> (ø%)`
... and 1089 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 224af7f...1d32bd3. Read the comment docs.

wu-sheng · 2020-09-15T08:45:15Z

CI fails too. Even I don't think CI tested this feature.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project apm-ehcache-2.x-plugin: Failed during checkstyle execution: Failed during checkstyle configuration: unable to parse configuration stream: Property ${import.control} has not been set -> [Help 1]

Property ${import.control} has not been set, I think this is the reason.

kezhenxu94 · 2020-09-15T09:06:03Z

I don't think that's what we recommend, we recommend to use mvnw with -f, which maybe also INCONVENIENT as what you said when the submodule is too DEEP, you have ../../../mvnw, if the pull request doesn't break anything (tests passed), I'm also OK to merge this

wu-sheng · 2020-09-15T09:18:45Z

if the pull request doesn't break anything (tests passed), I'm also OK to merge this

I am wondering why I can't pass compiling locally. Have a concern about this change

xbkaishui · 2020-09-15T09:40:06Z

let me double check,
In my local mac, I can switch to any module and just run mvn clean package , it will success

wu-sheng · 2020-09-15T09:53:09Z

mvn clean package is sensitive about the maven version, I used that too, but failed.

Wu-Sheng-s-MacBook-Pro:ehcache-2.x-plugin wusheng$ mvn package
[INFO] Scanning for projects...
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building ehcache-2.x-plugin 8.2.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
Downloading: https://repository.apache.org/snapshots/org/apache/skywalking/apm-sniffer/8.2.0-SNAPSHOT/maven-metadata.xml
Downloading: https://repository.apache.org/snapshots/org/apache/skywalking/apm/8.2.0-SNAPSHOT/maven-metadata.xml
Downloading: https://repository.apache.org/snapshots/org/apache/skywalking/apm-commons/8.2.0-SNAPSHOT/maven-metadata.xml
Downloading: https://repository.apache.org/snapshots/org/apache/skywalking/apm-test-tools/8.2.0-SNAPSHOT/maven-metadata.xml
[INFO] 
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-version) @ apm-ehcache-2.x-plugin ---
[INFO] 
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-java) @ apm-ehcache-2.x-plugin ---
[INFO] 
[INFO] --- os-maven-plugin:1.6.2:detect (default) @ apm-ehcache-2.x-plugin ---
[INFO] ------------------------------------------------------------------------
[INFO] Detecting the operating system and CPU architecture
[INFO] ------------------------------------------------------------------------
[INFO] os.detected.name: osx
[INFO] os.detected.arch: x86_64
[INFO] os.detected.version: 10.15
[INFO] os.detected.version.major: 10
[INFO] os.detected.version.minor: 15
[INFO] os.detected.classifier: osx-x86_64
[INFO] 
[INFO] --- maven-checkstyle-plugin:3.1.0:check (validate) @ apm-ehcache-2.x-plugin ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 7.388 s
[INFO] Finished at: 2020-09-15T16:24:45+08:00
[INFO] Final Memory: 18M/173M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project apm-ehcache-2.x-plugin: Failed during checkstyle execution: Failed during checkstyle configuration: unable to parse configuration stream: Property ${import.control} has not been set -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Wu-Sheng-s-MacBook-Pro:ehcache-2.x-plugin wusheng$ mvn package
[INFO] Scanning for projects...
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building ehcache-2.x-plugin 8.2.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO] 
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven-version) @ apm-ehcache-2.x-plugin ---
[INFO] 
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-java) @ apm-ehcache-2.x-plugin ---
[INFO] 
[INFO] --- os-maven-plugin:1.6.2:detect (default) @ apm-ehcache-2.x-plugin ---
[INFO] ------------------------------------------------------------------------
[INFO] Detecting the operating system and CPU architecture
[INFO] ------------------------------------------------------------------------
[INFO] os.detected.name: osx
[INFO] os.detected.arch: x86_64
[INFO] os.detected.version: 10.15
[INFO] os.detected.version.major: 10
[INFO] os.detected.version.minor: 15
[INFO] os.detected.classifier: osx-x86_64
[INFO] 
[INFO] --- maven-checkstyle-plugin:3.1.0:check (validate) @ apm-ehcache-2.x-plugin ---
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.672 s
[INFO] Finished at: 2020-09-15T16:25:54+08:00
[INFO] Final Memory: 15M/253M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on project apm-ehcache-2.x-plugin: Failed during checkstyle execution: Failed during checkstyle configuration: unable to parse configuration stream: Property ${import.control} has not been set -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Wu-Sheng-s-MacBook-Pro:ehcache-2.x-plugin wusheng$ mvn -version
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T00:41:47+08:00)
Maven home: /Users/wusheng/Documents/applications/apache-maven-3.3.9
Java version: 1.8.0_91, vendor: Oracle Corporation
Java home: /Users/wusheng/Documents/applications/jdk1.8.0_91.jdk/Contents/Home/jre
Default locale: zh_CN, platform encoding: UTF-8
OS name: "mac os x", version: "10.15.6", arch: "x86_64", family: "mac"

That is also why, @kezhenxu94 said, you will face another deep path because mvnw.

xbkaishui · 2020-09-15T10:03:38Z

The maven version should greater than 3.6, I also saw the e2e/pom.xml use this property

skywalking/test/e2e/pom.xml

Line 155 in 224af7f

    
           <configLocation>${maven.multiModuleProjectDirectory}/apm-checkstyle/checkStyle.xml</configLocation>

wu-sheng · 2020-09-15T10:05:40Z

mvnw provides that. But, local maven may be different version on different laptop.

xbkaishui · 2020-09-15T10:08:25Z

Can we enforce the maven version in main pom.xml , just like enforce the jdk version must greater than 1.8

wu-sheng · 2020-09-15T13:05:15Z

Is that possible?

xbkaishui · 2020-09-15T13:06:31Z

Yes, I can change it

xbkaishui · 2020-09-15T13:25:15Z

Hi @wu-sheng , added rule to check maven must greater than 3.6, please check in your local env

wu-sheng

It works, the document should be updated.

wu-sheng · 2020-09-15T13:37:30Z

pom.xml

                                    <version>1.8</version>
                                </requireJavaVersion>
+                                <requireMavenVersion>
+                                    <version>3.6</version>


This makes you need to update the compiling doc

https://github.com/apache/skywalking/blob/master/docs/en/guides/How-to-build.md#build-from-github

At least 3 places should be updated.

Prepare git, JDK8, and Maven 3.6+

Add document about compiling a single plugin in the Advanced compile part.

Remove Setup your Eclipse IDE section, it is out of the update.

Done, Please help to check (my poor english)

support build single module

c86d9f3

wu-sheng added the TBD To be decided later, need more discussion or input. label Sep 15, 2020

Merge branch 'master' into support-build-single-module

43384b0

enforce maven version must greater than 3.6

a321ad1

wu-sheng reviewed Sep 15, 2020

View reviewed changes

wu-sheng added CI settings CI settings adjustment documentation Provide documents related issue or pull request only. and removed TBD To be decided later, need more discussion or input. labels Sep 15, 2020

wu-sheng added this to the 8.2.0 milestone Sep 15, 2020

xbkaishui and others added 2 commits September 15, 2020 22:33

update build doc to support maven3.6+

498c806

Update How-to-build.md

1d32bd3

wu-sheng approved these changes Sep 15, 2020

View reviewed changes

wu-sheng requested a review from kezhenxu94 September 15, 2020 14:53

wu-sheng merged commit f397c1b into apache:master Sep 16, 2020

wu-sheng mentioned this pull request Nov 16, 2020

Update How-to-build.md SkyAPM/document-cn-translation-of-skywalking#52

Merged

Conversation

xbkaishui commented Sep 15, 2020

Bug fix

New feature or improvement

Uh oh!

wu-sheng commented Sep 15, 2020

Uh oh!

xbkaishui commented Sep 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Sep 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

wu-sheng commented Sep 15, 2020

Uh oh!

kezhenxu94 commented Sep 15, 2020

Uh oh!

wu-sheng commented Sep 15, 2020

Uh oh!

xbkaishui commented Sep 15, 2020

Uh oh!

wu-sheng commented Sep 15, 2020

Uh oh!

xbkaishui commented Sep 15, 2020

Uh oh!

wu-sheng commented Sep 15, 2020

Uh oh!

xbkaishui commented Sep 15, 2020

Uh oh!

wu-sheng commented Sep 15, 2020

Uh oh!

xbkaishui commented Sep 15, 2020

Uh oh!

xbkaishui commented Sep 15, 2020

Uh oh!

wu-sheng left a comment

Choose a reason for hiding this comment

Uh oh!

wu-sheng Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

wu-sheng Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

xbkaishui Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

xbkaishui commented Sep 15, 2020 •

edited

Loading

codecov bot commented Sep 15, 2020 •

edited

Loading