Skip to content

Support JDK 11 compiling and upgrade dependencies#5579

Merged
wu-sheng merged 10 commits intomasterfrom
upgrade-dependencies
Sep 29, 2020
Merged

Support JDK 11 compiling and upgrade dependencies#5579
wu-sheng merged 10 commits intomasterfrom
upgrade-dependencies

Conversation

@wu-sheng
Copy link
Member

Hi all @apache/skywalking-committers

According to OpenJDK website(https://adoptopenjdk.net/support.html), there are 2 TLS versions for now

  1. Java 8 (LTS). At Least May 2026
  2. Java 11 (LTS). At Least Oct 2024

We should make the JDK11 compiling passed. That is the primary agenda when I started this work. Also, with doing this, I planned to upgrade the gRPC too.
During the JDK11 compiling fix, the version of PowerMock was detected as the main block, so, I upgraded it to the 2.x directly.

So, you would note,

  1. Some libraries' versions(such as protobuf, protoc) changed because of gRPC or PowerMock requirements.
  2. Some tests are deleted because they are not valid in the latest PowerMock. Sorry, I don't have enough time to fix all, because some of them make no sense to me.
  3. LICENSE updated

If you have any concerns, please reply.

@wu-sheng wu-sheng added the core feature Core and important feature. Sometimes, break backwards compatibility. label Sep 28, 2020
@wu-sheng wu-sheng added this to the 8.2.0 milestone Sep 28, 2020
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #5579 into master will increase coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5579      +/-   ##
============================================
+ Coverage     51.69%   51.97%   +0.27%     
- Complexity     3327     3345      +18     
============================================
  Files          1607      898     -709     
  Lines         34107    22174   -11933     
  Branches       3713     2123    -1590     
============================================
- Hits          17632    11525    -6107     
+ Misses        15614     9723    -5891     
- Partials        861      926      +65     
Impacted Files Coverage Δ Complexity Δ
...p/server/core/analysis/metrics/MinLongMetrics.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...er/exporter/provider/grpc/GRPCExporterSetting.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...king/oap/server/configuration/api/ConfigTable.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...g/oap/server/cluster/plugin/etcd/EtcdEndpoint.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...skywalking/oap/server/receiver/envoy/als/Role.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
.../server/receiver/envoy/als/DependencyResource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...erver/cluster/plugin/consul/ConsulCoordinator.java 0.00% <0.00%> (-97.06%) 0.00% <0.00%> (ø%)
...ent/core/context/status/ExceptionCheckContext.java 0.00% <0.00%> (-90.91%) 0.00% <0.00%> (ø%)
...t/status/HierarchyMatchExceptionCheckStrategy.java 9.09% <0.00%> (-90.91%) 1.00% <0.00%> (ø%)
.../analysis/transform/Zipkin2SkyWalkingTransfer.java 0.00% <0.00%> (-90.91%) 0.00% <0.00%> (ø%)
... and 1105 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c17143...0071b39. Read the comment docs.

URI.class
})
@PowerMockIgnore({"javax.management.*"})
public class EtcdConfigWatcherRegisterTest {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kezhenxu94 @dmsolr @JaredTan95 This test can't pass on the GitHub Action's JDK11, but passed on the local JDK 11.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the GitHub Linux JDK1 env, this causes

jdk.internal.loader.ClassLoaderValue (in module java.base) because module java.base does not export jdk.internal.loader to unnamed module

NOTE, I changed the ignore to @PowerMockIgnore({"com.sun.org.apache.xerces.*", "javax.xml.*", "org.xml.*", "javax.management.*", "org.w3c.*"})

@wu-sheng wu-sheng merged commit 103cf00 into master Sep 29, 2020
@wu-sheng wu-sheng deleted the upgrade-dependencies branch September 29, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core feature Core and important feature. Sometimes, break backwards compatibility.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants