Support JDK 11 compiling and upgrade dependencies#5579
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5579 +/- ##
============================================
+ Coverage 51.69% 51.97% +0.27%
- Complexity 3327 3345 +18
============================================
Files 1607 898 -709
Lines 34107 22174 -11933
Branches 3713 2123 -1590
============================================
- Hits 17632 11525 -6107
+ Misses 15614 9723 -5891
- Partials 861 926 +65 Continue to review full report at Codecov.
|
| URI.class | ||
| }) | ||
| @PowerMockIgnore({"javax.management.*"}) | ||
| public class EtcdConfigWatcherRegisterTest { |
There was a problem hiding this comment.
@kezhenxu94 @dmsolr @JaredTan95 This test can't pass on the GitHub Action's JDK11, but passed on the local JDK 11.
There was a problem hiding this comment.
At the GitHub Linux JDK1 env, this causes
jdk.internal.loader.ClassLoaderValue (in module java.base) because module java.base does not export jdk.internal.loader to unnamed module
NOTE, I changed the ignore to @PowerMockIgnore({"com.sun.org.apache.xerces.*", "javax.xml.*", "org.xml.*", "javax.management.*", "org.w3c.*"})
Hi all @apache/skywalking-committers
According to OpenJDK website(https://adoptopenjdk.net/support.html), there are 2 TLS versions for now
We should make the JDK11 compiling passed. That is the primary agenda when I started this work. Also, with doing this, I planned to upgrade the gRPC too.
During the JDK11 compiling fix, the version of PowerMock was detected as the main block, so, I upgraded it to the 2.x directly.
So, you would note,
If you have any concerns, please reply.