Skip to content

Conversation

@ascrutae
Copy link
Member

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bug fix
  • New feature provided
  • Improve performance

Here is the bug report and resolve

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #5606 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5606      +/-   ##
============================================
- Coverage     52.28%   52.22%   -0.07%     
- Complexity     3358     3363       +5     
============================================
  Files           894      897       +3     
  Lines         22131    22169      +38     
  Branches       2120     2124       +4     
============================================
+ Hits          11572    11577       +5     
- Misses         9632     9661      +29     
- Partials        927      931       +4     
Impacted Files Coverage Δ Complexity Δ
...datacarrier/consumer/MultipleChannelsConsumer.java 77.08% <ø> (ø) 12.00 <0.00> (ø)
...atacarrier/partition/SimpleRollingPartitioner.java 75.00% <100.00%> (ø) 2.00 <0.00> (ø)
...g/oap/server/telemetry/api/HealthCheckMetrics.java 70.00% <0.00%> (-30.00%) 3.00% <0.00%> (-1.00%)
...r/cluster/plugin/standalone/StandaloneManager.java 77.77% <0.00%> (-22.23%) 3.00% <0.00%> (-1.00%)
...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java 50.70% <0.00%> (-5.64%) 12.00% <0.00%> (ø%)
...core/analysis/manual/instance/InstanceTraffic.java 56.00% <0.00%> (-4.00%) 7.00% <0.00%> (ø%)
...g/oap/server/telemetry/prometheus/BaseMetrics.java 86.66% <0.00%> (-3.34%) 8.00% <0.00%> (-1.00%)
...ng/oap/server/core/alarm/provider/RunningRule.java 45.45% <0.00%> (-1.82%) 11.00% <0.00%> (ø%)
...er/storage/plugin/influxdb/query/MetricsQuery.java 43.92% <0.00%> (-0.94%) 8.00% <0.00%> (-1.00%)
.../org/apache/skywalking/apm/toolkit/model/User.java
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f99a24...7638f82. Read the comment docs.

@wu-sheng wu-sheng added the chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. label Oct 1, 2020
@wu-sheng wu-sheng added this to the 8.2.0 milestone Oct 1, 2020
@wu-sheng wu-sheng merged commit 1cddb60 into apache:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants