Skip to content

fix TypeParameterUnusedInFormals#5613

Merged
wu-sheng merged 2 commits intoapache:masterfrom
x22x22:fix-TypeParameterUnusedInFormals
Oct 1, 2020
Merged

fix TypeParameterUnusedInFormals#5613
wu-sheng merged 2 commits intoapache:masterfrom
x22x22:fix-TypeParameterUnusedInFormals

Conversation

@x22x22
Copy link
Member

@x22x22 x22x22 commented Oct 1, 2020

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

Declaring a type parameter that is only used in the return type is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts at invocations of the method, and it interacts badly with method overload resolution.

this is false positive

  • How to fix?

@SuppressWarnings("TypeParameterUnusedInFormals")


New feature or improvement

  • Describe the details and related test reports.

@x22x22 x22x22 self-assigned this Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #5613 into master will decrease coverage by 11.71%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #5613       +/-   ##
=============================================
- Coverage     48.79%   37.08%   -11.72%     
+ Complexity     3161     2359      -802     
=============================================
  Files           899      900        +1     
  Lines         22108    22089       -19     
  Branches       2117     2117               
=============================================
- Hits          10788     8192     -2596     
- Misses        10437    13276     +2839     
+ Partials        883      621      -262     
Impacted Files Coverage Δ Complexity Δ
...ywalking/apm/agent/core/logging/core/LogLevel.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ywalking/apm/agent/core/plugin/EnhanceContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...ywalking/apm/agent/core/profile/ProfileStatus.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...walking/apm/agent/core/context/SW8CarrierItem.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...walking/apm/agent/core/logging/core/LogOutput.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...walking/apm/agent/core/plugin/match/NameMatch.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...alking/apm/agent/core/context/CarrierItemHead.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...alking/apm/agent/core/jvm/gc/ParallelGCModule.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ng/oap/server/core/analysis/config/NoneStream.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
... and 179 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eda834...9b87107. Read the comment docs.

@wu-sheng wu-sheng added chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. test Test requirements about performance, feature or before release. labels Oct 1, 2020
@wu-sheng wu-sheng added this to the 8.2.0 milestone Oct 1, 2020
@wu-sheng wu-sheng merged commit d30ca1a into apache:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. test Test requirements about performance, feature or before release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants