fix TypeParameterUnusedInFormals#5613
Merged
wu-sheng merged 2 commits intoapache:masterfrom Oct 1, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5613 +/- ##
=============================================
- Coverage 48.79% 37.08% -11.72%
+ Complexity 3161 2359 -802
=============================================
Files 899 900 +1
Lines 22108 22089 -19
Branches 2117 2117
=============================================
- Hits 10788 8192 -2596
- Misses 10437 13276 +2839
+ Partials 883 621 -262 Continue to review full report at Codecov.
|
wu-sheng
approved these changes
Oct 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
Why submit this pull request?
Bug fix
New feature provided
Improve performance
Related issues
Bug fix
Declaring a type parameter that is only used in the return type is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts at invocations of the method, and it interacts badly with method overload resolution.
this is false positive
@SuppressWarnings("TypeParameterUnusedInFormals")
New feature or improvement