Skip to content

Add syncBulkActions config to avoid the large amount of metrics data written ES in a single sync bulk request.#5699

Merged
kezhenxu94 merged 6 commits intoapache:masterfrom
Ax1an:master
Oct 21, 2020
Merged

Add syncBulkActions config to avoid the large amount of metrics data written ES in a single sync bulk request.#5699
kezhenxu94 merged 6 commits intoapache:masterfrom
Ax1an:master

Conversation

@Ax1an
Copy link
Copy Markdown
Member

@Ax1an Ax1an commented Oct 20, 2020

Please answer these questions before submitting a pull request

  • Why submit this pull request?

  • Bug fix

  • New feature provided

  • Improve performance

  • Related issues


Bug fix

  • Bug description.

  • How to fix?


New feature or improvement

  • Describe the details and related test reports.

    Add syncBulkActions config to avoid the large amount of metrics data written ES in a single bulk request.

image
image

@Ax1an Ax1an changed the title Add syncBulkActions config to avoid the large amount of metrics data written ES in a single bulk request. Add syncBulkActions config to avoid the large amount of metrics data written ES in a single sync bulk request. Oct 20, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 20, 2020

Codecov Report

Merging #5699 into master will decrease coverage by 53.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #5699       +/-   ##
============================================
- Coverage     53.10%   0.00%   -53.11%     
============================================
  Files           880     190      -690     
  Lines         21960    4371    -17589     
  Branches       2090     504     -1586     
============================================
- Hits          11662       0    -11662     
+ Misses         9365    4371     -4994     
+ Partials        933       0      -933     
Impacted Files Coverage Δ Complexity Δ
...ywalking/apm/agent/core/logging/core/LogLevel.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ywalking/apm/agent/core/plugin/EnhanceContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...ywalking/apm/agent/core/profile/ProfileStatus.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...walking/apm/agent/core/context/SW8CarrierItem.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...walking/apm/agent/core/logging/core/LogOutput.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...walking/apm/agent/core/plugin/match/NameMatch.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...alking/apm/agent/core/context/CarrierItemHead.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...alking/apm/agent/core/jvm/gc/ParallelGCModule.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...lking/apm/agent/core/remote/GRPCChannelStatus.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
... and 884 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fba656...47386e8. Read the comment docs.

Copy link
Copy Markdown
Member

@zifeihan zifeihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good.

@wu-sheng
Copy link
Copy Markdown
Member

Follow #5697 to update two change log files.

@wu-sheng
Copy link
Copy Markdown
Member

If you plan to merge this for now.

@wu-sheng wu-sheng added backend OAP backend related. TBD To be decided later, need more discussion or input. labels Oct 20, 2020
@wu-sheng wu-sheng removed the TBD To be decided later, need more discussion or input. label Oct 21, 2020
@wu-sheng wu-sheng added this to the 8.2.0 milestone Oct 21, 2020
@kezhenxu94 kezhenxu94 merged commit 287b8b9 into apache:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants