Skip to content

Conversation

@Hen1ng
Copy link
Contributor

@Hen1ng Hen1ng commented Oct 27, 2020

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #5733 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5733      +/-   ##
============================================
- Coverage     51.62%   51.58%   -0.04%     
+ Complexity     3452     3449       -3     
============================================
  Files          1637      922     -715     
  Lines         34937    22815   -12122     
  Branches       3806     2196    -1610     
============================================
- Hits          18036    11770    -6266     
+ Misses        16016    10098    -5918     
- Partials        885      947      +62     
Impacted Files Coverage Δ Complexity Δ
...ent/core/plugin/jdk9module/JDK9ModuleExporter.java 73.91% <ø> (+3.07%) 4.00 <0.00> (ø)
...che/skywalking/apm/agent/core/meter/MeterType.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...e/skywalking/apm/agent/core/meter/CounterMode.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...org/apache/skywalking/apm/toolkit/meter/Gauge.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...ng/apm/agent/core/context/trace/LogDataEntity.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...p/server/core/analysis/metrics/MinLongMetrics.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...er/exporter/provider/grpc/GRPCExporterSetting.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...core/plugin/bytebuddy/AnnotationTypeNameMatch.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...king/oap/server/configuration/api/ConfigTable.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
... and 1127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6858cf...995939d. Read the comment docs.

@kezhenxu94 kezhenxu94 added the documentation Provide documents related issue or pull request only. label Oct 27, 2020
@kezhenxu94 kezhenxu94 added this to the 8.3.0 milestone Oct 27, 2020
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks

@kezhenxu94 kezhenxu94 changed the title fix Fix incomplete JavaDoc Oct 27, 2020
@kezhenxu94 kezhenxu94 merged commit b5e7d17 into apache:master Oct 27, 2020
@Hen1ng Hen1ng deleted the fix branch June 30, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Provide documents related issue or pull request only.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants