Skip to content

[Plugin] added component ID for Python aiohttp#6006

Merged
wu-sheng merged 3 commits intoapache:masterfrom
tom-pytel:plugin-python-aiohttp
Dec 14, 2020
Merged

[Plugin] added component ID for Python aiohttp#6006
wu-sheng merged 3 commits intoapache:masterfrom
tom-pytel:plugin-python-aiohttp

Conversation

@tom-pytel
Copy link
Contributor

@tom-pytel tom-pytel commented Dec 14, 2020

Added component ID for Python plugin for module aiohttp.

Add an agent plugin to support Python aiohttp module

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@kezhenxu94 kezhenxu94 added plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. python Python agent related labels Dec 14, 2020
@kezhenxu94 kezhenxu94 added this to the 8.4.0 milestone Dec 14, 2020
kezhenxu94
kezhenxu94 previously approved these changes Dec 14, 2020
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changlog should be updated as new component id added.

@codecov
Copy link

codecov bot commented Dec 14, 2020

Codecov Report

Merging #6006 (18d6229) into master (62b690b) will decrease coverage by 0.57%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6006      +/-   ##
============================================
- Coverage     51.28%   50.71%   -0.58%     
+ Complexity     3516     3457      -59     
============================================
  Files          1680     1680              
  Lines         35749    35748       -1     
  Branches       3949     3949              
============================================
- Hits          18335    18129     -206     
- Misses        16485    16692     +207     
+ Partials        929      927       -2     
Impacted Files Coverage Δ Complexity Δ
...ing/oap/server/library/util/ProtoBufJsonUtils.java 0.00% <0.00%> (-90.00%) 0.00% <0.00%> (-2.00%)
...s/manual/database/DatabaseStatementDispatcher.java 10.00% <0.00%> (-90.00%) 1.00% <0.00%> (-1.00%)
...tworkalias/NetworkAddressAliasSetupDispatcher.java 11.11% <0.00%> (-88.89%) 1.00% <0.00%> (-1.00%)
...ler/v8/rest/ManagementServiceKeepAliveHandler.java 32.00% <0.00%> (-64.00%) 2.00% <0.00%> (-1.00%)
...rest/ManagementServiceReportPropertiesHandler.java 27.58% <0.00%> (-62.07%) 2.00% <0.00%> (-2.00%)
...er/core/server/auth/AuthenticationInterceptor.java 0.00% <0.00%> (-61.54%) 0.00% <0.00%> (-3.00%)
...lysis/manual/networkalias/NetworkAddressAlias.java 2.43% <0.00%> (-60.98%) 0.00% <0.00%> (-6.00%)
...p/server/core/source/NetworkAddressAliasSetup.java 33.33% <0.00%> (-50.01%) 2.00% <0.00%> (-1.00%)
...er/sharing/server/ReceiverGRPCHandlerRegister.java 30.76% <0.00%> (-46.16%) 2.00% <0.00%> (-3.00%)
...r/listener/NetworkAddressAliasMappingListener.java 36.36% <0.00%> (-39.40%) 4.00% <0.00%> (-1.00%)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62b690b...8345cc8. Read the comment docs.

@tom-pytel
Copy link
Contributor Author

I think changlog should be updated as new component id added.

Done

@wu-sheng wu-sheng merged commit 065a797 into apache:master Dec 14, 2020
@tom-pytel tom-pytel deleted the plugin-python-aiohttp branch December 15, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. python Python agent related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants