Skip to content

Comments

Add metrics and logging tags for this repo#6088

Merged
wu-sheng merged 1 commit intomasterfrom
wu-sheng-patch-1
Dec 28, 2020
Merged

Add metrics and logging tags for this repo#6088
wu-sheng merged 1 commit intomasterfrom
wu-sheng-patch-1

Conversation

@wu-sheng
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@wu-sheng wu-sheng added the chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. label Dec 28, 2020
@wu-sheng wu-sheng added this to the 8.4.0 milestone Dec 28, 2020
@wu-sheng wu-sheng requested a review from a team December 28, 2020 00:56
Copy link
Contributor

@hanahmily hanahmily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 28, 2020

Codecov Report

Merging #6088 (05094da) into master (462c685) will decrease coverage by 7.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6088      +/-   ##
============================================
- Coverage     51.40%   44.29%   -7.11%     
+ Complexity     3516     2845     -671     
============================================
  Files          1692     1691       -1     
  Lines         35803    35761      -42     
  Branches       3959     3967       +8     
============================================
- Hits          18404    15842    -2562     
- Misses        16463    18977    +2514     
- Partials        936      942       +6     
Impacted Files Coverage Δ Complexity Δ
...skywalking/oap/server/core/alarm/AlarmMessage.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...p/server/receiver/zipkin/ZipkinReceiverConfig.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ng/oap/server/storage/plugin/jdbc/SQLExecutor.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...server/storage/plugin/influxdb/base/RecordDAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...er/storage/plugin/influxdb/base/NoneStreamDAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...op/server/receiver/mesh/MeshGRPCHandlerCompat.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...erver/storage/plugin/jdbc/h2/dao/H2StorageDAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...storage/plugin/influxdb/base/InfluxStorageDAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...rage/plugin/influxdb/base/InfluxInsertRequest.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-8.00%)
.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 462c685...05094da. Read the comment docs.

@wu-sheng wu-sheng merged commit 1f01246 into master Dec 28, 2020
@wu-sheng wu-sheng deleted the wu-sheng-patch-1 branch December 28, 2020 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants