Skip to content

LogQuery remove unused field#6246

Merged
wu-sheng merged 1 commit intoapache:masterfrom
rainbend:log
Jan 24, 2021
Merged

LogQuery remove unused field#6246
wu-sheng merged 1 commit intoapache:masterfrom
rainbend:log

Conversation

@rainbend
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@rainbend rainbend added the backend OAP backend related. label Jan 24, 2021
@rainbend rainbend added this to the 8.4.0 milestone Jan 24, 2021
@rainbend rainbend requested review from Fine0830 and wu-sheng January 24, 2021 09:21
@rainbend rainbend added the submodule update Change submodule commit ID, including network protocol, query GraphQL and UI label Jan 24, 2021
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FYI @Fine0830

@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #6246 (90328ef) into master (777c670) will increase coverage by 0.00%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6246   +/-   ##
=========================================
  Coverage     52.47%   52.48%           
+ Complexity     3788     3785    -3     
=========================================
  Files          1747     1747           
  Lines         37009    37008    -1     
  Branches       4093     4093           
=========================================
+ Hits          19422    19423    +1     
+ Misses        16624    16622    -2     
  Partials        963      963           
Impacted Files Coverage Δ Complexity Δ
...walking/oap/server/core/query/LogQueryService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ng/oap/server/core/storage/query/ILogQueryDAO.java 71.42% <ø> (ø) 3.00 <0.00> (ø)
...kywalking/oap/query/graphql/resolver/LogQuery.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...rage/plugin/elasticsearch/query/LogQueryEsDAO.java 2.63% <0.00%> (ø) 1.00 <0.00> (ø)
...ge/plugin/elasticsearch7/query/LogQueryEs7DAO.java 2.63% <0.00%> (ø) 1.00 <0.00> (ø)
...server/storage/plugin/influxdb/query/LogQuery.java 5.00% <0.00%> (ø) 2.00 <0.00> (ø)
...rver/storage/plugin/jdbc/h2/dao/H2LogQueryDAO.java 73.78% <100.00%> (ø) 9.00 <0.00> (ø)
...g/oap/server/telemetry/prometheus/BaseMetrics.java 96.77% <0.00%> (+3.22%) 10.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 777c670...90328ef. Read the comment docs.

@wu-sheng wu-sheng merged commit 0bd8149 into apache:master Jan 24, 2021
@rainbend rainbend deleted the log branch January 24, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. submodule update Change submodule commit ID, including network protocol, query GraphQL and UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants