Skip to content

Comments

add text analyzer for es#6249

Merged
wu-sheng merged 12 commits intoapache:masterfrom
EvanLjp:es-text-analyzer
Jan 25, 2021
Merged

add text analyzer for es#6249
wu-sheng merged 12 commits intoapache:masterfrom
EvanLjp:es-text-analyzer

Conversation

@EvanLjp
Copy link
Member

@EvanLjp EvanLjp commented Jan 24, 2021

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@EvanLjp EvanLjp added backend OAP backend related. feature New feature labels Jan 24, 2021
@EvanLjp EvanLjp added this to the 8.4.0 milestone Jan 24, 2021
@EvanLjp
Copy link
Member Author

EvanLjp commented Jan 24, 2021

let's define a default log text analyzer first, would add doc later. @wu-sheng @arugal

@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #6249 (530671a) into master (20a7675) will decrease coverage by 1.52%.
The diff coverage is 83.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6249      +/-   ##
============================================
- Coverage     52.49%   50.97%   -1.53%     
+ Complexity     3784     3631     -153     
============================================
  Files          1747     1748       +1     
  Lines         37008    37066      +58     
  Branches       4093     4102       +9     
============================================
- Hits          19428    18893     -535     
- Misses        16615    17201     +586     
- Partials        965      972       +7     
Impacted Files Coverage Δ Complexity Δ
...er/core/analysis/manual/log/AbstractLogRecord.java 10.52% <ø> (ø) 1.00 <0.00> (ø)
...age/plugin/elasticsearch/base/AnalyzerSetting.java 68.57% <68.57%> (ø) 3.00 <3.00> (?)
.../skywalking/oap/meter/analyzer/dsl/Expression.java 70.17% <100.00%> (+1.65%) 7.00 <0.00> (ø)
...ing/oap/server/core/storage/annotation/Column.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ing/oap/server/core/storage/model/ModelColumn.java 100.00% <100.00%> (ø) 4.00 <4.00> (ø)
...g/oap/server/core/storage/model/StorageModels.java 88.73% <100.00%> (+0.16%) 21.00 <0.00> (ø)
...lasticsearch/StorageModuleElasticsearchConfig.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)
.../plugin/elasticsearch/base/StorageEsInstaller.java 83.72% <100.00%> (+2.14%) 17.00 <2.00> (+2.00)
...rver/core/browser/source/BrowserErrorCategory.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-8.00%)
...core/browser/source/BrowserAppTrafficCategory.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c52aa02...2ccc118. Read the comment docs.

@EvanLjp EvanLjp requested a review from wu-sheng January 25, 2021 05:21
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu-sheng wu-sheng merged commit e138d29 into apache:master Jan 25, 2021
@wu-sheng wu-sheng linked an issue Jan 26, 2021 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add log analyzer in es storage

2 participants