Skip to content

Conversation

@cutePanda123
Copy link
Contributor

@cutePanda123 cutePanda123 commented Feb 27, 2021

Fix: remove duplicate CallbackAdapter file #6457

  • Add a unit test to verify that the fix works.
  • Explain briefly why the bug exists and how to fix it.
    What I did: remove the duplicate CallbackAdapter.java file

@cutePanda123 cutePanda123 changed the title removed a duplicate file removed the duplicate CallbackAdapter.java file Feb 27, 2021
@cutePanda123 cutePanda123 changed the title removed the duplicate CallbackAdapter.java file fix: removed the duplicate CallbackAdapter.java file Feb 27, 2021
@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #6458 (c45c084) into master (3a6c39c) will decrease coverage by 8.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6458      +/-   ##
============================================
- Coverage     53.70%   45.48%   -8.22%     
+ Complexity     4085     2691    -1394     
============================================
  Files          1790     1792       +2     
  Lines         38273    38292      +19     
  Branches       4228     4198      -30     
============================================
- Hits          20554    17419    -3135     
- Misses        16716    19875    +3159     
+ Partials       1003      998       -5     
Impacted Files Coverage Δ Complexity Δ
...skywalking/oap/server/core/alarm/AlarmMessage.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ywalking/apm/agent/core/plugin/EnhanceContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-5.00%)
...walking/apm/agent/core/plugin/match/NameMatch.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ng/oap/server/core/analysis/config/NoneStream.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
.../apm/agent/core/context/ids/PropagatedTraceId.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...lking/oap/server/analyzer/event/EventAnalyzer.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...rver/core/browser/source/BrowserErrorCategory.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-8.00%)
...core/browser/source/BrowserAppTrafficCategory.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ore/analysis/metrics/expression/NotEqualMatch.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...log/analyzer/provider/log/ILogAnalyzerService.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
... and 296 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6c39c...c45c084. Read the comment docs.

@wu-sheng wu-sheng added this to the 8.5.0 milestone Feb 27, 2021
@wu-sheng wu-sheng added the chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. label Feb 27, 2021
@wu-sheng wu-sheng merged commit 258962c into apache:master Feb 27, 2021
@cutePanda123 cutePanda123 deleted the users/cutepanda/first-pr-remove-duplicate-callbackadapter branch February 27, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Why are there two copies of CallbackAdapter.java?

2 participants