-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Update the agent HBase plugin to support HBase Client 2.x #6577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
41b3a23 to
f45ab9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share the naming rule of 100, 200, and 220?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
100 -> 1.0.0, means adapt version [1.0.0,1.6.0), 1.6.0 is the latest 1.x currently.
200 -> 2.0.0, means adapt version [2.0.0, 2.1.9), 2.1.9 is the latest 2.1.x currently.
220 -> 2.2.0, means adapt version [2.2.0, 2.4.1), 2.4.1 is the latest 2.x currently.
I use the start version as the name because we don't know what is the newest future version
wu-sheng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Supported-list.md should be updated
- Plugin e2e tests should be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the comments here about #6577 (comment). We need to be clear about the naming rules.
Codecov Report
@@ Coverage Diff @@
## master #6577 +/- ##
=============================================
+ Coverage 32.88% 52.64% +19.75%
- Complexity 2374 4063 +1689
=============================================
Files 996 1796 +800
Lines 24360 38521 +14161
Branches 2395 4209 +1814
=============================================
+ Hits 8011 20279 +12268
- Misses 15755 17261 +1506
- Partials 594 981 +387 Continue to review full report at Codecov.
|
|
Please don't close and reopen, You are making all CI process rerun. |
|
After reading these docs as follows: You said that update the e2e test, does it meaning I just need to update the
|
It depends on which way you prefer? Does the client API change much? Which makes you have to separate the test cases? |
NO, but the HTable constructor function change in different versions.
According to the difference constructor, we need different versions of maven dependency, or we will miss some scenarios. |
So, you can't use the same test codebase for different versions, right? If so, feel free to separate the cases. |
The test code will be the same or similar, just the maven dependency version is different. We need to cover the HBase agent plugin for the different logic. In my opinion, it still should separate the cases. |
Then you could add versions into the here, https://github.com/apache/skywalking/blob/master/test/plugin/scenarios/hbase-scenario/support-version.list. The test framework will cover the versions. |
f45ab9c to
f9fbf0e
Compare
I had added the comment about naming rules and update the |
This missed. |
Update the agent HBase plugin to support HBase Client 2.x
Add a test case for the new plugin, refer to the doc
Add a component id in the component-libraries.yml
Add a logo in the UI repo
Relate the issue hbase-1.x-plugin is not compatible with 2.x hbase-client #6572
Update the
CHANGESlog.In HBase Client 2.x, the
HTableconstructor function has a little difference after2.2.0.So the agent plugin should have 3
ConstructorInterceptPoint, I have tested it all intest/plugin/scenarios/hbase-scenario, just change the dependency version.The e2e test cases haven't committed, I will commit it later. Please take a look first, thanks.