Conversation
Member
Author
|
@nisiyong Please take a look. |
Codecov Report
@@ Coverage Diff @@
## master #6687 +/- ##
=============================================
+ Coverage 47.25% 58.97% +11.72%
- Complexity 3391 4214 +823
=============================================
Files 1792 999 -793
Lines 38412 25066 -13346
Branches 4234 2447 -1787
=============================================
- Hits 18152 14783 -3369
+ Misses 19265 9006 -10259
- Partials 995 1277 +282 Continue to review full report at Codecov.
|
Contributor
👍I try it tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
This bug was introduced through @arugal 's #4748. As we changed the loading priority and sequence of the OAL scripts, it did make sure disable statements could be found before loading hardcoded metric/record/...
I add a new
disable.oal, and give it the highest priority. Alldisablestatements have to be put in there.CHANGESlog.