Skip to content

Conversation

@YunfengGao
Copy link
Contributor

1.take 'getUrl' out of inner loop for better performance
2.use try-with-resources auto close CloseableHttpClient

1.take 'getUrl' out of inner loop for better performance
2.use try-with-resources auto close CloseableHttpClient
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #6773 (4ccf317) into master (3a7d6c0) will increase coverage by 13.62%.
The diff coverage is 50.00%.

❗ Current head 4ccf317 differs from pull request most recent head 384b956. Consider uploading reports for the commit 384b956 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master    #6773       +/-   ##
=============================================
+ Coverage     40.54%   54.17%   +13.62%     
- Complexity     2975     4189     +1214     
=============================================
  Files           973     1802      +829     
  Lines         23976    38606    +14630     
  Branches       2346     4271     +1925     
=============================================
+ Hits           9720    20913    +11193     
- Misses        13421    16688     +3267     
- Partials        835     1005      +170     
Impacted Files Coverage Δ Complexity Δ
.../alarm/provider/dingtalk/DingtalkHookCallback.java 75.86% <50.00%> (+60.34%) 3.00 <0.00> (+1.00)
...erver/receiver/envoy/MetricServiceGRPCHandler.java 31.81% <0.00%> (-61.52%) 3.00% <0.00%> (ø%)
...er/receiver/envoy/AccessLogServiceGRPCHandler.java 18.51% <0.00%> (-37.04%) 2.00% <0.00%> (ø%)
...king/aop/server/receiver/mesh/MeshGRPCHandler.java 60.00% <0.00%> (-15.00%) 3.00% <0.00%> (+1.00%) ⬇️
...server/core/analysis/worker/AlarmNotifyWorker.java 85.71% <0.00%> (-14.29%) 3.00% <0.00%> (ø%)
.../server/core/analysis/data/ReadWriteSafeCache.java 68.18% <0.00%> (-10.77%) 3.00% <0.00%> (ø%)
...erver/core/analysis/data/MergableBufferedData.java 66.66% <0.00%> (-10.26%) 4.00% <0.00%> (ø%)
...lemetry/prometheus/PrometheusHistogramMetrics.java 70.58% <0.00%> (-9.42%) 2.00% <0.00%> (ø%)
...y/prometheus/httpserver/HttpServerInitializer.java 62.50% <0.00%> (-8.93%) 1.00% <0.00%> (ø%)
...ywalking/apm/agent/core/context/tag/StringTag.java 66.66% <0.00%> (-8.34%) 3.00% <0.00%> (ø%)
... and 1376 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a7d6c0...384b956. Read the comment docs.

@wu-sheng wu-sheng added chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. backend OAP backend related. labels Apr 16, 2021
@wu-sheng wu-sheng added this to the 8.6.0 milestone Apr 16, 2021
@wu-sheng wu-sheng merged commit 7f2dc00 into apache:master Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants