Skip to content

Conversation

@liqiangz
Copy link
Member

@liqiangz liqiangz commented May 6, 2021

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #6899 (4a16ad4) into master (17fffe8) will decrease coverage by 25.90%.
The diff coverage is n/a.

❗ Current head 4a16ad4 differs from pull request most recent head 246f260. Consider uploading reports for the commit 246f260 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master    #6899       +/-   ##
=============================================
- Coverage     54.45%   28.55%   -25.91%     
=============================================
  Files          1844     1741      -103     
  Lines         39358    36516     -2842     
  Branches       4360     4812      +452     
=============================================
- Hits          21434    10426    -11008     
- Misses        16905    25097     +8192     
+ Partials       1019      993       -26     
Impacted Files Coverage Δ Complexity Δ
...apm/plugin/okhttp/common/AsyncCallInterceptor.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...g/apm/plugin/okhttp/common/EnqueueInterceptor.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...apm/plugin/okhttp/common/OnFailureInterceptor.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...pm/plugin/okhttp/common/OnResponseInterceptor.java 0.00% <ø> (ø) 0.00 <0.00> (?)
.../apm/plugin/okhttp/common/RealCallInterceptor.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...he/skywalking/oal/rt/output/DispatcherContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...skywalking/oal/rt/output/AllDispatcherContext.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
...ache/skywalking/oap/server/core/source/Source.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...che/skywalking/oap/server/core/source/Service.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...che/skywalking/oap/server/core/source/SideCar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-1.00%)
... and 859 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fffe8...246f260. Read the comment docs.

@wu-sheng wu-sheng requested review from EvanLjp and kezhenxu94 May 6, 2021 09:36
@wu-sheng wu-sheng added agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor. labels May 6, 2021
@wu-sheng wu-sheng added this to the 8.6.0 milestone May 6, 2021
@wu-sheng
Copy link
Member

wu-sheng commented May 6, 2021

@kezhenxu94 @EvanLjp Please check on codes. The tests seem good.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

EDIT:

Dead Link Checker is fixed in my PR so just ignore it in this PR

@EvanLjp
Copy link
Member

EvanLjp commented May 6, 2021

LGTM. And the tests seems passed.

@wu-sheng wu-sheng merged commit b934a14 into apache:master May 6, 2021
@liqiangz liqiangz deleted the okhttp branch May 18, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Language agent related. feature New feature plugin Plugin for agent or collector. Be used to extend the capabilities of default implementor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants