Conversation
| } | ||
|
|
||
| // todo javadoc | ||
| public void remove(ModuleManager manager, String metricName, Class<? extends Metrics> metricsClass) { |
There was a problem hiding this comment.
Tip, we need to check whether the worker would be GC successfully to avoid potential OOM risk.
There was a problem hiding this comment.
Question, once this gets removed, we don't touch the storage, right?
|
Let's be clear, in this PR, we focus on MAL update through physical file changing, right? We need to update the doc to indicate this. |
|
@dmsolr Any update about this? |
|
SkyWalking Metrics data comes from MeterSystem and OALEngine. The source of
Currently, we have had the Prometheus Fetcher which scraps metrics sampling from the Prometheus exporter. It could convert Prometheus Metrics to MeterSystem's Sample by MAL rules. There are 3 types of operators, ADD, UPDATE and DELETE.
Above description is not suitation for ElasticSearch. In RMDBS(mysql/postgresql), tidb and influxdb. A metrics represent a model, and a table(measuremnt in influxdb). And the table name is the mode name. So, for update,
In ElasticSearch(after #6499), have many difference with other storage plugins. SW has put all metrics into one index. And identified metrics data by the function name and mode name.
In ElasticSearch case, there is no error cause by MAL updated. |
Does this mean OAP exiting? |
|
Yes. If OAP has had the same name rule exist and its expression different, we call it |
This could happen from time to time in the debug mode, if this keeps exiting, I think this feature is going to useless. |
It is better to disable it if you have any concerns. But don't run in exit. |
We talk about non-elasticsearch case, right? (ES should not interrupt because MAL updated) I got your point and agreed. That means do not interrupt OAP server. So, rename the table. WDYT? |
I think directly dropping table is fine. We could disable hot update in default. |
|
The PR still takes a long time to complete, so I closed it first before it is ready. |

CHANGESlog.#6897