Skip to content

Fix, make sure time bucket exists in service traffic.#7237

Closed
wu-sheng wants to merge 1 commit intomasterfrom
service_traffic_timebucket
Closed

Fix, make sure time bucket exists in service traffic.#7237
wu-sheng wants to merge 1 commit intomasterfrom
service_traffic_timebucket

Conversation

@wu-sheng
Copy link
Member

@wu-sheng wu-sheng commented Jul 3, 2021

According to @dmsolr feedback, if there is no time bucket in service traffic, the InfluxDB storage could make the data duplicated in the storage.

Let's try this in the e2e, but don't merge until we finish the discussion.

@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! backend OAP backend related. labels Jul 3, 2021
@wu-sheng wu-sheng added this to the 8.7.0 milestone Jul 3, 2021
@wu-sheng wu-sheng requested review from dmsolr and kezhenxu94 July 3, 2021 02:34
@codecov
Copy link

codecov bot commented Jul 3, 2021

Codecov Report

Merging #7237 (a388eee) into master (0f62d92) will increase coverage by 1.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7237      +/-   ##
============================================
+ Coverage     51.66%   52.84%   +1.18%     
- Complexity     4151     4276     +125     
============================================
  Files          1900     1900              
  Lines         40922    40936      +14     
  Branches       4594     4594              
============================================
+ Hits          21142    21633     +491     
+ Misses        18688    18214     -474     
+ Partials       1092     1089       -3     
Impacted Files Coverage Δ
...r/core/analysis/manual/service/ServiceTraffic.java 68.57% <100.00%> (+1.90%) ⬆️
...storage/plugin/jdbc/h2/dao/H2HistoryDeleteDAO.java 14.28% <0.00%> (-66.67%) ⬇️
...ary/client/healthcheck/DelegatedHealthChecker.java 60.00% <0.00%> (-20.00%) ⬇️
...pm/agent/core/remote/EventReportServiceClient.java 75.67% <0.00%> (-10.82%) ⬇️
...lysis/manual/networkalias/NetworkAddressAlias.java 58.53% <0.00%> (-4.88%) ⬇️
...skywalking/apm/agent/core/boot/ServiceManager.java 75.00% <0.00%> (-2.95%) ⬇️
...brary/client/jdbc/hikaricp/JDBCHikariCPClient.java 63.38% <0.00%> (-2.82%) ⬇️
...trace/parser/listener/SegmentAnalysisListener.java 75.29% <0.00%> (+1.17%) ⬆️
...rver/storage/plugin/influxdb/query/AlarmQuery.java 80.00% <0.00%> (+1.66%) ⬆️
...g/oap/server/telemetry/prometheus/BaseMetrics.java 87.09% <0.00%> (+3.22%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f62d92...a388eee. Read the comment docs.

@kezhenxu94
Copy link
Member

Seems no help

@wu-sheng wu-sheng closed this Jul 3, 2021
@wu-sheng wu-sheng deleted the service_traffic_timebucket branch July 3, 2021 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. bug Something isn't working and you are sure it's a bug!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Locate e2e failing, InfluxDB e2e tests.

2 participants