Fix issues in ElasticSearch 7.14 and add log cases to ES7.14#7429
Fix issues in ElasticSearch 7.14 and add log cases to ES7.14#7429kezhenxu94 merged 1 commit intomasterfrom
Conversation
wu-sheng
left a comment
There was a problem hiding this comment.
Let's limit the not null in the certain scopes.
.../main/java/org/apache/skywalking/oap/server/core/analysis/manual/service/ServiceTraffic.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/skywalking/oap/server/core/analysis/manual/endpoint/EndpointTraffic.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/skywalking/oap/server/core/analysis/manual/segment/SegmentRecord.java
Show resolved
Hide resolved
...n/src/main/java/org/apache/skywalking/oap/server/storage/plugin/zipkin/ZipkinSpanRecord.java
Outdated
Show resolved
Hide resolved
The nullability check is added according to whether they are annotated with |
Codecov Report
@@ Coverage Diff @@
## master #7429 +/- ##
============================================
- Coverage 53.14% 52.30% -0.85%
+ Complexity 4335 4005 -330
============================================
Files 1899 1034 -865
Lines 41163 26449 -14714
Branches 4620 2620 -2000
============================================
- Hits 21877 13833 -8044
+ Misses 18152 11408 -6744
- Partials 1134 1208 +74
Continue to review full report at Codecov.
|
The changes on the log side are reasonable, and should be done. But why we bother to check these |
mapper_parsing_exceptionin ElasticSearch 7.14 #7425.CHANGESlog.