Fix ZookeeperConfigWatcherRegister.readConfig() could cause NPE when data.getData() is null#7611
Merged
Merged
Conversation
…hen `data.getData()` is null
wankai123
added
bug
kezhenxu94
approved these changes
Aug 31, 2021
wu-sheng
added a commit
that referenced
this pull request
Aug 31, 2021
* master: (41 commits) Fix `ZookeeperConfigWatcherRegister.readConfig()` could cause `NPE` when `data.getData()` is null (#7611) Fix dynamic configuration watch implementation current value not null when the config is deleted. (#7606) Fix CI job `check-dependency-license` failure (#7601) Support configure sampling rate dynamically for service dimension on the backend side (#7554) Use new GitHub issue form template (#7604) Refine backend doc (#7595) Update mal.md (#7596) Update menu.yml (#7594) Remove menu of java agent doc. (#7593) Remove agent codes and clean up (#7588) refine backend doc (#7587) Doc: Reorganize dynamic configuration doc (#7586) sync ui and update CHANGES log (#7585) Fix issue#7527, add desc sort function in IBrowserLogQueryDAO of H2 and ES (#7580) Move shardingsphere plugins into one folder (#7546) Escape `.` in `String.replaceFirst` as it acts as a wildcard (#7576) Fix dead link (#7575) Support k8s configmap grouped dynamic configurations (#7570) Fix dead link (#7560) refine backend doc (#7559) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
ZookeeperConfigWatcherRegister.readConfig()could causeNPEwhendata.getData()is nullAdd a unit test to verify that the fix works.
Explain briefly why the bug exists and how to fix it.
If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
Update the
CHANGESlog.new String(data.getData())could cause NPE, when clear data bytes or set data byte[] null.