Conversation
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
kezhenxu94
left a comment
kezhenxu94
left a comment
There was a problem hiding this comment.
Also, FYI, I'm merging apache/skywalking-docker into this repo (and the java-agent part into apache/skywalking-java) apache/skywalking-docker#24 (comment).
| # limitations under the License. | ||
|
|
||
| ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine' | ||
| ARG BASE_IMAGE='adoptopenjdk/openjdk11:alpine-jre' |
There was a problem hiding this comment.
We need to update
so that different versions ofjre can be tested.
There was a problem hiding this comment.
Gotcha. I also found some other openjdk in e2e tests, for example, istio relevant cases.
There was a problem hiding this comment.
Do we have jre agent image already?
There was a problem hiding this comment.
Do we have jre agent image already?
For Java agent, no, it's still using JDK
There was a problem hiding this comment.
OK, seems we should take care of it later.
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
Signed-off-by: Gao Hongtao <hanahmily@gmail.com>
hanahmily
force-pushed
the
docker-jre
branch
from
335bbe4 to
d852728
Compare
@kezhenxu94 This seems definitely showing up in the agent testing. But always be good in other tests. I think something breaking. |
|
@kezhenxu94 Should we keep merging this? I think we have no clue about the mvnw issue. |
Let's merge this |
3 participants
Fixed #7597