Skip to content

Comments

Remove fake required workflows#8692

Merged
wu-sheng merged 1 commit intomasterfrom
remove-fake-jobs
Mar 17, 2022
Merged

Remove fake required workflows#8692
wu-sheng merged 1 commit intomasterfrom
remove-fake-jobs

Conversation

@kezhenxu94
Copy link
Member

Follow up #8691 , remove those fake jobs that was only used to pass the CI

@kezhenxu94 kezhenxu94 added CI settings CI settings adjustment chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. labels Mar 17, 2022
@kezhenxu94 kezhenxu94 added this to the 9.0.0 milestone Mar 17, 2022
@kezhenxu94 kezhenxu94 force-pushed the remove-fake-jobs branch 2 times, most recently from 371740b to 95d4dbc Compare March 17, 2022 02:25
@wu-sheng
Copy link
Member

Required is controlled by the GHA file, rather than settings, now?

@kezhenxu94
Copy link
Member Author

Required is controlled by the GHA file, rather than settings, now?

I had changed the required context name to Required in last PR and now we can use this single name to aggregate all mandatory jobs, so no need to have several fake jobs,

@kezhenxu94 kezhenxu94 marked this pull request as ready for review March 17, 2022 02:29
@wu-sheng
Copy link
Member

I see. Then we need this gets merged before other PRs.

@kezhenxu94
Copy link
Member Author

I see. Then we need this gets merged before other PRs.

Actually not necessary, the fake Required workflow is also added in last PR so all new PRs can be merged, this PR is only to remove those unused ones

@kezhenxu94 kezhenxu94 requested a review from wu-sheng March 17, 2022 03:27
@wu-sheng wu-sheng merged commit eccca85 into master Mar 17, 2022
@wu-sheng wu-sheng deleted the remove-fake-jobs branch March 17, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. CI settings CI settings adjustment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants