Merged
Conversation
wu-sheng
reviewed
Apr 28, 2022
| * Add data-generator module to run OAP in testing mode, generating mock data for testing. | ||
| * Support receive Kubernetes processes from gRPC protocol. | ||
| * Fix the problem that es index(TimeSeriesTable, eg. endpoint_traffic, alarm_record) didn't create even after rerun with init-mode. This problem caused the OAP server to fail to start when the OAP server was down for more than a day. | ||
| * Clean up scroll contexts after used. |
Member
There was a problem hiding this comment.
Would this cause OOM or something?
Member
Author
There was a problem hiding this comment.
Usually this is not a critical problem as the context has an expiration time (30s), but in high volume of clusters (millions of service /network aliases that the all results cannot be retrieved within the expiration time) this would cause
Trying to create too many scroll contexts. Must be less than or equal to: [500]. This limit can be set by changing the [search.max_open_scroll_context] setting
Member
Author
|
After I verified I'll mark it "Ready for review", before that let's hold this |
kezhenxu94
force-pushed
the
clean-scroll-context
branch
6 times, most recently
from
4729f28 to
98e5cd4
Compare
kezhenxu94
force-pushed
the
clean-scroll-context
branch
from
98e5cd4 to
d71c076
Compare
kezhenxu94
added
backend
wu-sheng
approved these changes
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.