Skip to content

Remove Prometheuse fetcher, fix MAL Histogram type bug, and reorganize the doc#9710

Merged
wu-sheng merged 4 commits intoapache:masterfrom
kezhenxu94:chore/remove-prom-fetcher
Sep 30, 2022
Merged

Remove Prometheuse fetcher, fix MAL Histogram type bug, and reorganize the doc#9710
wu-sheng merged 4 commits intoapache:masterfrom
kezhenxu94:chore/remove-prom-fetcher

Conversation

@kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 commented Sep 29, 2022 •
edited
Loading

@wu-sheng wu-sheng added bug Something isn't working and you are sure it's a bug! backend OAP backend related. high priority High priority issue, blocking next release. labels Sep 29, 2022
@wu-sheng wu-sheng added this to the 9.3.0 milestone Sep 29, 2022
wu-sheng
wu-sheng reviewed Sep 29, 2022
View reviewed changes
@kezhenxu94 kezhenxu94 force-pushed the chore/remove-prom-fetcher branch from 6a6521f to 8f8967c Compare September 29, 2022 04:16
@sonatype-lift
Copy link

sonatype-lift bot commented Sep 29, 2022

⚠️ 6 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@wu-sheng
Copy link
Member

wu-sheng commented Sep 29, 2022

There seems one UT failing, it seems relative.

wu-sheng
wu-sheng reviewed Sep 29, 2022
View reviewed changes
@kezhenxu94 kezhenxu94 force-pushed the chore/remove-prom-fetcher branch from 8f8967c to 48b70fe Compare September 29, 2022 10:41
@kezhenxu94 kezhenxu94 force-pushed the chore/remove-prom-fetcher branch from 48b70fe to 7cc6e1a Compare September 29, 2022 14:08
wu-sheng
wu-sheng previously approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once e2e passed.

wankai123
wankai123 previously approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@wankai123 wankai123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wu-sheng
wu-sheng previously approved these changes Sep 30, 2022
View reviewed changes
wu-sheng
wu-sheng reviewed Sep 30, 2022
View reviewed changes
@kezhenxu94 kezhenxu94 dismissed stale reviews from wu-sheng and wankai123 via 1e7d29f September 30, 2022 02:40
@wu-sheng wu-sheng merged commit dd6b7a1 into apache:master Sep 30, 2022
@kezhenxu94 kezhenxu94 deleted the chore/remove-prom-fetcher branch September 30, 2022 05:14
@wu-sheng wu-sheng mentioned this pull request Sep 30, 2022
Merged
@kezhenxu94 kezhenxu94 mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wu-sheng wu-sheng wu-sheng approved these changes

@wankai123 wankai123 wankai123 left review comments

@hanahmily hanahmily Awaiting requested review from hanahmily

+1 more reviewer

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backend OAP backend related. bug Something isn't working and you are sure it's a bug! high priority High priority issue, blocking next release.

Projects

None yet

Milestone

9.3.0

Development

Successfully merging this pull request may close these issues.

[Bug] OpenTelemetryMetricHandler Histogram buildBucket

3 participants

@kezhenxu94 @wu-sheng @wankai123

Comments