Remove lengthEnvVariable for Column as it never works as expected#9952
Merged
kezhenxu94 merged 1 commit intoapache:masterfrom Nov 12, 2022
Merged
Remove lengthEnvVariable for Column as it never works as expected#9952kezhenxu94 merged 1 commit intoapache:masterfrom
lengthEnvVariable for Column as it never works as expected#9952kezhenxu94 merged 1 commit intoapache:masterfrom
Conversation
wu-sheng
approved these changes
Nov 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.This was introduced in #5238 and it never works as expected so I just remove this and won't consider it as breaking change.
In #5238 we meant to add
lengthEnvVariableas an mechanism to override the column length, but the env var it uses isSW_SLOW_DB_THRESHOLD, which is the duration threshold instead of length threshold, what's more, the content ofSW_SLOW_DB_THRESHOLDis something likedefault:200,mongodb:100butStorageModelsalways tries to parse the content ofSW_SLOW_DB_THRESHOLDas an integer, which causes the following errors