SLING-10054 remove emma-maven-plugin and related profiles#14
Merged
Conversation
all code-coverage is now done with jacoco-maven-plugin
|
Kudos, SonarCloud Quality Gate passed!
|
rombert
reviewed
Jan 11, 2021
Contributor
rombert
left a comment
rombert
left a comment
There was a problem hiding this comment.
LGTM, but I'm not that familiar with it. I think @bdelacretaz also worked on it, maybe he can say whether it's safe to remove it.
Member
Author
|
Given that emma-maven-plugin is no longer maintained and the last release was in 2010 I would remove it. In case someone needs the profile we need to look for another way to generate the coverage report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all code-coverage is now done with jacoco-maven-plugin