Skip to content

SLING-10715 configure Maven site header with logos, GH ribbon,#20

Merged
kwin merged 1 commit intomasterfrom
feature/common-site-descriptor
Aug 10, 2021
Merged

SLING-10715 configure Maven site header with logos, GH ribbon,#20
kwin merged 1 commit intomasterfrom
feature/common-site-descriptor

Conversation

@kwin
Copy link
Copy Markdown
Member

@kwin kwin commented Aug 9, 2021

breadcrumb and edit button

A site generated of a Maven plugin derived from this parent looks like outlined in https://issues.apache.org/jira/secure/attachment/13031658/Screenshot%202021-08-09%20at%2018.37.10.png

@kwin kwin requested review from raducotescu and rombert August 9, 2021 16:42
Copy link
Copy Markdown
Contributor

@rombert rombert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I think it would also be very nice to have a more friendly rendering of https://sling.apache.org/components/, but probably needs a completely different approach as it's just a directory and not managed by the Maven tooling.

@kwin
Copy link
Copy Markdown
Member Author

kwin commented Aug 10, 2021

I think it would also be very nice to have a more friendly rendering of https://sling.apache.org/components/, but probably needs a completely different approach as it's just a directory and not managed by the Maven tooling.

This requires a custom JBake template in sling-site.

@kwin kwin merged commit e021f17 into master Aug 10, 2021
@rombert
Copy link
Copy Markdown
Contributor

rombert commented Aug 30, 2021

I think it would also be very nice to have a more friendly rendering of https://sling.apache.org/components/, but probably needs a completely different approach as it's just a directory and not managed by the Maven tooling.

This requires a custom JBake template in sling-site.

https://issues.apache.org/jira/browse/SLING-10764

@kwin kwin deleted the feature/common-site-descriptor branch May 23, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants