Skip to content

SLING-7452 Document the handling of multiple value fields with SlingPostServlet#7

Closed
dplaton wants to merge 4 commits intoapache:masterfrom
dplaton:master
Closed

SLING-7452 Document the handling of multiple value fields with SlingPostServlet#7
dplaton wants to merge 4 commits intoapache:masterfrom
dplaton:master

Conversation

@dplaton
Copy link

@dplaton dplaton commented Jan 29, 2018

Please review and merge accordingly.

Thank you.

@dplaton dplaton changed the title SLING-2393 - Update Post Servlet Documentation for patch operation SLING-7452 Document the handling of multiple value fields with SlingPostServlet Jan 29, 2018
@dplaton
Copy link
Author

dplaton commented Jan 29, 2018

I see that the changes are already documented at http://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#patch

Wouldn't make sense to have this at least moved in the "Multiple values" section?

@rombert
Copy link
Contributor

rombert commented Jan 30, 2018

@dplaton - would it work if you added a link from the 'multiple values' section to the 'patch' section? Also it would be good to review if your changes have any additions/clarifications over the current docs.

…gPostServlet

Add a link to the `@Patch` suffix documentation in the "Multiple values" section.
@dplaton
Copy link
Author

dplaton commented Jan 30, 2018

Ok @rombert , I added a link to the 'patch' section. That section covers everything there is to know.

@rombert
Copy link
Contributor

rombert commented Jan 30, 2018

I know I'm nitpicking, but there's already an auto-generated patch anchor - https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#patch . Can you use that instead?

@dplaton
Copy link
Author

dplaton commented Jan 30, 2018

Ok, I wanted to use an internal link instead of the long one.

…gPostServlet

Add the link to the existing generated anchor
@rombert
Copy link
Contributor

rombert commented Jan 30, 2018

Can't you use '#patch' as a link?

@dplaton
Copy link
Author

dplaton commented Jan 30, 2018

My editor didn't recognize the link when I used #patch so I thought is not supported.

@rombert
Copy link
Contributor

rombert commented Jan 30, 2018

It's auto-generated by the markdown template, so the editor can't know about it.

…gPostServlet

Update the link to point only to the anchor, not to the whole URL.
@rombert rombert closed this in 97a36f9 Jan 30, 2018
@rombert
Copy link
Contributor

rombert commented Jan 30, 2018

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants