Skip to content

8.11.2-fixing-urls to be in-sync#17

Merged
HoustonPutman merged 1 commit into
apache:mainfrom
olevchyk:8.11.2-fixing-urls
Jan 25, 2024
Merged

8.11.2-fixing-urls to be in-sync#17
HoustonPutman merged 1 commit into
apache:mainfrom
olevchyk:8.11.2-fixing-urls

Conversation

@olevchyk
Copy link
Copy Markdown
Contributor

@olevchyk olevchyk commented Jan 23, 2024

SOLR_CLOSER_URL for 8.11.2 version is currently broken, not sure what would be the correct source but I set it to be the same as for 8.11.2 at https://solr.apache.org/downloads.html

Comment thread 8.11-slim/Dockerfile Outdated
@janhoy
Copy link
Copy Markdown
Contributor

janhoy commented Jan 23, 2024

Curious, how did you notice this? Won't the Dockerfile simply fallback to using SOLR_DIST_URL and SOLR_ARCHIVE_URL and it still works?

@olevchyk
Copy link
Copy Markdown
Contributor Author

olevchyk commented Jan 23, 2024

Curious, how did you notice this? Won't the Dockerfile simply fallback to using SOLR_DIST_URL and SOLR_ARCHIVE_URL and it still works?

attaching the part of the build log

0.248 + [ -n  ]
0.249 + [ -f /opt/solr-8.11.2.tgz ]
0.249 + echo downloading http://www.apache.org/dyn/closer.lua?filename=lucene/solr/8.11.2/solr-8.11.2.tgz&action=download
0.249 + wget -t 10 --max-redirect 1 --retry-connrefused -nv http://www.apache.org/dyn/closer.lua?filename=lucene/solr/8.11.2/solr-8.11.2.tgz&action=download -O /opt/solr-8.11.2.tgz
0.249 downloading http://www.apache.org/dyn/closer.lua?filename=lucene/solr/8.11.2/solr-8.11.2.tgz&action=download
0.506 1 redirections exceeded.
0.515 + rm -f /opt/solr-8.11.2.tgz
0.517 + [ -f /opt/solr-8.11.2.tgz ]
0.517 + echo downloading https://www.apache.org/dist/lucene/solr/8.11.2/solr-8.11.2.tgz
0.517 + wget -t 10 --max-redirect 1 --retry-connrefused -nv https://www.apache.org/dist/lucene/solr/8.11.2/solr-8.11.2.tgz -O /opt/solr-8.11.2.tgz
0.517 downloading https://www.apache.org/dist/lucene/solr/8.11.2/solr-8.11.2.tgz
0.864 2024-01-23 20:58:16 URL:https://downloads.apache.org/ [28487] -> "/opt/solr-8.11.2.tgz" [1]
0.866 + break
0.866 + [ ! -f /opt/solr-8.11.2.tgz ]
0.866 + [ -z  ]
0.866 + echo downloading https://archive.apache.org/dist/lucene/solr/8.11.2/solr-8.11.2.tgz.asc
0.866 + wget -nv https://archive.apache.org/dist/lucene/solr/8.11.2/solr-8.11.2.tgz.asc -O /opt/solr-8.11.2.tgz.asc
0.866 downloading https://archive.apache.org/dist/lucene/solr/8.11.2/solr-8.11.2.tgz.asc
1.055 2024-01-23 20:58:16 URL:https://archive.apache.org/dist/lucene/solr/8.11.2/solr-8.11.2.tgz.asc [833/833] -> "/opt/solr-8.11.2.tgz.asc" [1]
1.057 + echo 22fedcc0090eda72c3c5a5ea769c93adaf7d92c5c4479993f009ef0b9d42de5bd2ed1e0565ca01f3428587d8a3836286aa3017aab157050f2bd5bc3482fdebaa */opt/solr-8.11.2.tgz
1.057 + sha512sum -c -
1.058 /opt/solr-8.11.2.tgz: FAILED
1.058 sha512sum: WARNING: 1 computed checksum did NOT match

you're right, the first one fails and then the 2nd wget successfully downloads Index of from SOLR_DIST_URL instead of the actual package
https://www.apache.org/dist/lucene/solr/8.11.2/solr-8.11.2.tgz which later fails sha512sum
the right URL seems to be
https://downloads.apache.org/lucene/solr/8.11.2/solr-8.11.2.tgz for 8.11.2 release
and
https://downloads.apache.org/solr/solr/9.4.1/solr-9.4.1.tgz for latest release.

ideally this redirect shouldn't cut the request path , but I guess it's also fine as long as it works for the latest releases (additionally dist has to be cut in the rewrite )

curl -Il "https://www.apache.org/dist/lucene/solr/8.11.2/solr-8.11.2.tgz"                                    
HTTP/2 301 
server: Apache
location: https://downloads.apache.org/

Im updating a few other references of https://www.apache.org/dist/ in the last commit

Copy link
Copy Markdown
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.
In reality with the new CDN there is only no need for the closer script, so probably the Dockerfile could be simplified to DIST and archive. @HoustonPutman ?

Copy link
Copy Markdown
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we really don't want to have to change from downloads to archive when a new release is available, so I think the closer script is still the way to go (And what is suggested by apache) for the 9.3+ Dockerfiles, just easier to have one URL that will always work.

This looks good to me as well. I've tried building all of the images and it works.

@HoustonPutman HoustonPutman merged commit e383a55 into apache:main Jan 25, 2024
docker-solr-builder pushed a commit to docker-solr/official-images that referenced this pull request Jan 25, 2024
yosifkit added a commit to docker-library/official-images that referenced this pull request Jan 25, 2024
Apache Solr - Fix 8.11.2 URLs, and improve other version URLs (apache/solr-docker#17)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants