8.11.2-fixing-urls to be in-sync#17
Conversation
|
Curious, how did you notice this? Won't the Dockerfile simply fallback to using SOLR_DIST_URL and SOLR_ARCHIVE_URL and it still works? |
attaching the part of the build log you're right, the first one fails and then the 2nd wget successfully downloads ideally this redirect shouldn't cut the request path , but I guess it's also fine as long as it works for the latest releases (additionally dist has to be cut in the rewrite ) Im updating a few other references of https://www.apache.org/dist/ in the last commit |
455f388 to
b1d5efc
Compare
janhoy
left a comment
There was a problem hiding this comment.
This looks good to me.
In reality with the new CDN there is only no need for the closer script, so probably the Dockerfile could be simplified to DIST and archive. @HoustonPutman ?
HoustonPutman
left a comment
There was a problem hiding this comment.
So we really don't want to have to change from downloads to archive when a new release is available, so I think the closer script is still the way to go (And what is suggested by apache) for the 9.3+ Dockerfiles, just easier to have one URL that will always work.
This looks good to me as well. I've tried building all of the images and it works.
Apache Solr - Fix 8.11.2 URLs, and improve other version URLs (apache/solr-docker#17)
SOLR_CLOSER_URL for 8.11.2 version is currently broken, not sure what would be the correct source but I set it to be the same as for 8.11.2 at https://solr.apache.org/downloads.html