fix: propagate errors from listCollections() instead of returning empty list#112
Merged
epugh merged 1 commit intoMay 8, 2026
Merged
Conversation
adityamparikh
force-pushed
the
fix/list-collections-error-propagation
branch
from
9e51255 to
baeaa55
Compare
…ty list When Solr is unreachable, listCollections() was catching SolrServerException/IOException and returning an empty list. This caused the MCP client to incorrectly tell users "there are no collections" instead of reporting a connection error. Remove the try-catch and let checked exceptions propagate through listCollections(), validateCollectionExists(), and their callers so the MCP framework can surface a proper error to the client. Closes #3 Signed-off-by: Aditya Parikh <aditya.m.parikh@gmail.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: adityamparikh <aditya.m.parikh@gmail.com>
adityamparikh
force-pushed
the
fix/list-collections-error-propagation
branch
from
baeaa55 to
2d40162
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listCollections()-- letSolrServerException/IOExceptionpropagateTest plan
./gradlew buildpasses./gradlew nativeTest -Pnativepasses (119/119 tests)🤖 Generated with Claude Code