Helm chart: fix rolebindings when watching multiple namespaces

[plumdog]

Found that I was getting errors like:

error retrieving resource lock mynamespace1/88488bdc.solr.apache.org: leases.coordination.k8s.io "88488bdc.solr.apache.org" is forbidden: User "system:serviceaccount:system:solr-operator" cannot get resource "leases" in API group "coordination.k8s.io" in the namespace "mynamespace1"

I have deployed with the following values:

watchNamespaces: mynamespace1,mynamespace2

When I did a helm diff to switch off leader elections, I saw something like the following in the diff:

- # Source: solr-operator/templates/leader_election_role_binding.yaml
...
- apiVersion: rbac.authorization.k8s.io/v1
- kind: RoleBinding
- metadata:
-   name: solr-operator-leader-election-rolebinding
-   namespace: mynamespace1
- roleRef:
-   apiGroup: rbac.authorization.k8s.io
-   kind: Role
-   name: solr-operator-leader-election-role
- subjects:
-   - kind: ServiceAccount
-     name: solr-operator
-     namespace: system
- apiVersion: rbac.authorization.k8s.io/v1
- kind: RoleBinding
- metadata:
-   name: solr-operator-leader-election-rolebinding
-   namespace: mynamespace2
- roleRef:
-   apiGroup: rbac.authorization.k8s.io
-   kind: Role
-   name: solr-operator-leader-election-role
- subjects:
-   - kind: ServiceAccount
-     name: solr-operator
-     namespace: system

Which looks right, except for the missing ---, which is what this PR adds.

My workaround is to run with:

leaderElection:
  enable: false
replicaCount: 1

(1 is the default number of replicas anyway, but I imagine strange things happen with multiple replicas and no leader election, so important it is set to 1)

[HoustonPutman]

Great catch and fix, thanks so much for taking the time!

Would you mind adding a changelog entry real quick in the solr-operator helm chart yaml? You can add it to the end of the list, and just link the PR since this doesn't have an issue.

[plumdog]

@HoustonPutman Happy to help!

I think I have now put the right thing into Chart.yaml.