Ability to customize default initContainer resources#451
Merged
HoustonPutman merged 6 commits intoapache:mainfrom Jul 7, 2022
Merged
Ability to customize default initContainer resources#451HoustonPutman merged 6 commits intoapache:mainfrom
HoustonPutman merged 6 commits intoapache:mainfrom
Conversation
huijieliu
reviewed
Jul 6, 2022
| } | ||
|
|
||
| volumePrepResources := corev1.ResourceList{ | ||
| corev1.ResourceCPU: *DefaultSolrVolumePrepInitContainerCPU, |
There was a problem hiding this comment.
👏This will help to make sure if we configure our solr resources with limit=request as well, the pod will get assigned with QoS class Guaranteed
| {{- toYaml .Values.podOptions.topologySpreadConstraints | nindent 2 }} | ||
| {{ end }} | ||
| {{- if .Values.podOptions.defaultInitContainerResources -}} | ||
| defaultInitContainerResources: |
There was a problem hiding this comment.
discussed offline, using default resource to configure both init container resource should be good for now if we need to custom init container resources as both are light weight init containers.
gerlowskija
approved these changes
Jul 7, 2022
api/v1beta1/common_types.go
Outdated
Contributor
There was a problem hiding this comment.
[0] Looks like this comment is out of sync with the new field-name you ultimately went with here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #448
The new SolrCloud option is
Spec.customSolrKubeOptions.podOptions.defaultInitContainerResources.The option can also be enabled in the Solr Helm chart through:
podOptions.defaultInitContainerResources.The default initContainers will also come with default resources starting with this PR.