Add Solr ZK Connection Options#456
Merged
gerlowskija merged 7 commits intoapache:mainfrom Jul 27, 2022
Merged
Conversation
Contributor
|
Alright, I've taken a crack at the remaining TODOs (tests, helm chart exposure, and docs). This should be ready for review if anyone gets a chance! |
gerlowskija
reviewed
Jul 27, 2022
| testGenericPodEnvVariablesWithGomega(g, expectedEnvVars, foundEnvVars, "SOLR_OPTS", resolveOffset(additionalOffset)) | ||
| } | ||
|
|
||
| func testMetricsPodEnvVariables(expectedEnvVars map[string]string, foundEnvVars []corev1.EnvVar, additionalOffset ...int) { |
Contributor
There was a problem hiding this comment.
These methods were all able to be merged, as the only thing differentiating them previously was the env-var that they required to be last.
HoustonPutman
commented
Jul 27, 2022
Contributor
Author
HoustonPutman
left a comment
HoustonPutman
left a comment
There was a problem hiding this comment.
I can't approve this because it's my PR, but:
Absolutely beautiful, especially the new checks for EnvVar dependencies.
LGTM to merge!
gerlowskija
approved these changes
Jul 27, 2022
Contributor
|
Hah, but it lets me Approve despite having the latest commits on the branch 🤷 Thanks for the review Houston! Bit more manual testing but plan to merge this afternoon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #435
This is a bit broader than the Issue, but should be easier for users to setup.
Still to do: