Migrate packaging from setup.py to pyproject.toml#22
Merged
Conversation
# Conflicts: # setup.py # tox.ini
- Fix MANIFEST.in: include min-version.txt (not min-os-version.txt) - Upgrade pytest-benchmark to >=4.0.0 to fix py.io.TerminalWriter error on Python 3.12 - Update PYTHON_SUPPORT_GUIDE.md: replace setup.py/tox.ini refs with pyproject.toml - Makefile: enforce tox>=4 when installing tox for it/it312/it313 targets
- .coveragerc: remove setup.py from coverage omit list (file no longer exists) - run.sh: rename install_osbenchmark_with_setuptools -> install_osbenchmark and remove misleading setup.py comment (function uses pip install, not setup.py)
pyproject.toml [tool.tox] config requires tox 4+. The previous check only installed tox when missing; now it also upgrades if the installed version is older than 4.
…GUIDE.md The .github/workflows/integ-tests.yml file does not exist in this repo. Python version support is driven solely by .ci/variables.json and pyproject.toml.
pytest-benchmark 3.x uses py.io.TerminalWriter which was removed from the py library in 1.11+, causing an INTERNALERROR on Python 3.12. The upgrade to >=4.0.0 is intentional and necessary for Python 3.12 compatibility.
epugh
approved these changes
May 25, 2026
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
Sure, I guess this is the direction folks are going in ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Replaces
setup.py,setup.cfg, andtox.iniwith a singlepyproject.tomlcontaining all package metadata, dependencies, and tool configuration (pytest, tox).All 1090 unit tests pass.