Skip to content

Solr CrossDC Consumer Helm chart.#67

Closed
sigram wants to merge 3 commits intoapache:mainfrom
lucidworks:4109-consumer-helm-chart
Closed

Solr CrossDC Consumer Helm chart.#67
sigram wants to merge 3 commits intoapache:mainfrom
lucidworks:4109-consumer-helm-chart

Conversation

@sigram
Copy link
Contributor

@sigram sigram commented Sep 6, 2023

Simple Helm chart with a deployment descriptor, and a Jib-based image build.

I added a wrapper to make it easier to pass configuration properties through environment. We could also roll this into the base Consumer class.

@sigram sigram requested a review from anshumg September 13, 2023 09:39
@sigram sigram requested a review from markrmiller October 13, 2023 16:39
@HoustonPutman
Copy link
Contributor

So I'm not against this having a docker image, but when we merge this cross dc stuff into the Solr repository, it will likely not have its own docker image (much like the prometheus exporter). So I'm not sure its worth merging this in the meantime.

Also the helm chart is very lightweight and could really be replaced by a kubectl run <name> --image=solr/solr-crossdc-consumer:latest --env="VARIABLE=value", so I'm not sure it's really bringing much to the table. Might be a useful thing to add to the Solr Operator at some point though.

@sigram
Copy link
Contributor Author

sigram commented Oct 24, 2023

@HoustonPutman thanks, this makes sense - closing.

@sigram sigram closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants