Documents lost in Consumer during target Solr restart.#73
Closed
sigram wants to merge 1 commit intoapache:mainfrom
Closed
Documents lost in Consumer during target Solr restart.#73sigram wants to merge 1 commit intoapache:mainfrom
sigram wants to merge 1 commit intoapache:mainfrom
Conversation
Member
|
Taking a look. |
Member
|
Good catch, big hole that that test only tests dropping zk and not Solr. I'm just wrapping up a fix. Appears to be caused by batching multiple Kafka records to a SolrRequest to send to Solr, but on failure, adding back just the last Kafka record, so of course you loose the previous records in the batch. |
Contributor
Author
|
If I'm not mistaken this has been fixed in PR 75? if so then this can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modified test illustrates a scenario when target Solr node(s) go missing (for example due to a crash, a forced restart, or connectivity issues) BUT at the same time the Zookeeper remains online.
The test fails because it looks like some of the documents are lost by the Consumer, even though the
failed_resubmitcode path should resubmit them back to Kafka and they should be picked up later when Solr is back online.