Add the requet back to the queue on fail, not just the last record.#75
Merged
markrmiller merged 1 commit intoapache:mainfrom Oct 3, 2023
Merged
Add the requet back to the queue on fail, not just the last record.#75markrmiller merged 1 commit intoapache:mainfrom
markrmiller merged 1 commit intoapache:mainfrom
Conversation
sigram
approved these changes
Oct 3, 2023
| } | ||
| metrics.counter("failed-resubmit").inc(); | ||
| kafkaMirroringSink.submit(record.value()); | ||
| kafkaMirroringSink.submit(result.newItem()); |
Contributor
There was a problem hiding this comment.
this should do the trick :)
BTW, I don't like the name _newItem and this method suggests as if we were creating something new, which we're not. Why not item and getItem() ?
Member
Author
There was a problem hiding this comment.
I honestly have no clue. I started on this from Anshum's original dump that he extracted from some older code that did other things and integrated with other components. I don't understand much about the naming in that class, and since I haven't really had to touch before, it's just kind of survived. I'll make sure to refactor it in a cleanup issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.