-
Notifications
You must be signed in to change notification settings - Fork 33
Common Posts page #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Common Posts page #161
Conversation
|
I considered also folding in the "SECURITY" menu here, but that one is more than just security posts.
|
|
Nice work Jan! |
gerlowskija
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code for this all looks great!
The only feedback I'd offer is on the naming: I don't think "Posts" is terribly clear as an entry in the header-bar or as the title for the umbrella page. Wdyt of maybe "Announcements" or even keeping "News" as the umbrella page title? (If we keep "News" as the umbrella term, the "sub-content-types" could be "Announcements" and "Blog Posts")
+1 - regardless of whatever names we end up landing on.
It would be a bit weird if the menu says "News" but the page name is I agree that "Posts" is not the best name. Are you folks OK with using a different name in menu than in URL? I.e. label the menu "News", even if the page you land on is not called "news" and contains sub menus "Announcements", "Security", "Blog", where the announcements page has |
I see what you mean; that is kindof "weird" and I wasn't really thinking about the link-breaking problem when I suggested the above. I'd be 👍 with the alternative you suggested (where the menu name doesn't strictly match the URL). Though if someone with more web experience comes in to say that's a bad idea, I'd defer to their experience. I'm pretty out of my element here. |
|
"Feed" instead of "Posts"? FWIW I'm indifferent, and +1 to either path described above. |
Introduce a common "Posts" page that lists all News, Security-news and Blog posts chronologically.
The page will be the only one linked in the header menu.
It will have links to (existing) news.html and blog.html on the top.
Clicking a title on the posts list will bring you to the existing location of the post/blog, so no broken links.
The posts page has pagination.
New page:



Existing blog page (with a back link):
Existing news page (with a back link):