Skip to content

Conversation

@dsmiley
Copy link
Contributor

@dsmiley dsmiley commented Oct 11, 2025

in any SolrCloud command that accepts it.

It remains defaulted to false in 9, but will become true and likely removed.

https://issues.apache.org/jira/browse/SOLR-17712

This PR is very focused on only deprecations to also land on Solr 9. Crediting @abumarjikar . #3684 goes further with change of default

  in any SolrCloud command that accepts it.

It remains defaulted to false in 9, but will become true and likely removed.
@psalagnac
Copy link
Contributor

Should the @Deprecated methods in SolrJ be marked with forRemoval=true ?
This is a good sign users should actually try to not use them.

@dsmiley
Copy link
Contributor Author

dsmiley commented Oct 15, 2025

I was only recently aware of forRemoval and I'm disappointed it defaults to false. I'll update this PR accordingly and merge tomorrow.

@epugh
Copy link
Contributor

epugh commented Oct 15, 2025

We don't really have super strong patterns around how we label things. I think forRemoval is a nice thing, but then you might want a since etc ;-).

This reverts commit c894b6e.
@dsmiley
Copy link
Contributor Author

dsmiley commented Oct 16, 2025

It seems precommit is unhappy that we call the methods still with that forRemoval=true aspect. I don't want to deal with the matter so I reverted it, as we haven't been using that option. I'm more likely, going forward, to explicitly set it to false on something if I want to warn people not to use that might not be going away. I'll merge in a bit.

@dsmiley dsmiley merged commit 6eb910a into apache:main Oct 17, 2025
3 of 4 checks passed
@dsmiley dsmiley deleted the SOLR-17712-deprecateWaitForFinalState branch October 17, 2025 00:01
dsmiley added a commit that referenced this pull request Oct 17, 2025
* SOLR-17712: Deprecating waitForFinalState parameter
  in any SolrCloud command that accepts it.

It remains defaulted to false in 9, but will become true and likely removed.
dsmiley added a commit that referenced this pull request Oct 17, 2025
  in any SolrCloud command that accepts it.

It remains defaulted to false in 9, but will become true and likely removed.

(cherry picked from commit 6eb910a)
dsmiley added a commit that referenced this pull request Oct 23, 2025
* SOLR-17712: Deprecating waitForFinalState parameter
  in any SolrCloud command that accepts it.

It remains defaulted to false in 9, but will become true and likely removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants