-
Notifications
You must be signed in to change notification settings - Fork 789
New runDev alternative to "dev" #3816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
epugh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Thanks for the docs
| println "To attach a debugger, at the CLI pass: --debug-jvm" | ||
| println "To pass JVM args, at the CLI pass: -PjvmArgs='--add-modules jdk.incubator.vector'" | ||
| println "To pass system properties, at the CLI pass: -Djetty.port=8983" | ||
| println "To pass system properties, at the CLI pass: -Dsolr.port.listen=8983" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
dev-docs/gradle-help/workflow.txt
Outdated
| gradlew -p solr/packaging dev | ||
| ls solr/packaging/build/dev # expanded directory | ||
| Build & run Solr directly from Gradle, skipping "bin/solr", retaining data between runs: | ||
| gradlew -p solr/packaging runDevSlim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a runDev to match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like there to be one for ease of remembering it. But I want the slim thing to be the default, not "full". I could just rename this to "runDev" and stop there. Later we can decide if we want to bother with offering a full as well. WDYT?
IMO "dev" should also just be an alias to "devSlim". If you want full, call devFull. I disagree with "dev" building both. WDYT @HoustonPutman ? (I recall you introduced this in 2023).
And for another aside... the name "dev" is not something I would have chosen... I think it was Dawid Weiss who thought of something quickly and there wasn't feedback at the time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I think we could always rename it..
|
It's now |
(cherry picked from commit d6c8095)
(cherry picked from commit d6c8095)
This introduces a convenient way to start Solr from Gradle, which I think is thus the most convenient way to start Solr period. It relies on
devSlim. Note that IntelliJ can run Gradle tasks (action "Execute Gradle Task"), which in turn makes debugging simple, as you just need to hit the debug symbol.Downsides / trade-offs: