Skip to content

[SPARK-43367] Recover sh in dockerfile#41

Closed
Yikun wants to merge 1 commit intoapache:masterfrom
Yikun:SPARK-43367
Closed

[SPARK-43367] Recover sh in dockerfile#41
Yikun wants to merge 1 commit intoapache:masterfrom
Yikun:SPARK-43367

Conversation

@Yikun
Copy link
Member

@Yikun Yikun commented May 25, 2023

What changes were proposed in this pull request?

Recover sh, we remove sh due to https://github.com/apache-spark-on-k8s/spark/pull/444/files#r134075892 , now SPARK_DRIVER_JAVA_OPTS related code already move to entrypoint.sh with #!/bin/bash, so we don't need this hack way.

See also:
[1] docker-library/official-images#13089 (comment)
[2] docker-library/official-images#13089 (comment)

Why are the changes needed?

Recover sh

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun Yikun marked this pull request as ready for review May 25, 2023 11:06
@Yikun Yikun closed this in ce3e122 May 25, 2023
@Yikun
Copy link
Member Author

Yikun commented May 25, 2023

@HyukjinKwon Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants