[SPARK-49453] Add quotes for number #112
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| data: | ||
| # Spark Operator Config Runtime Properties Overrides. e.g. | ||
| spark.kubernetes.operator.reconciler.intervalSeconds: 60 | ||
| spark.kubernetes.operator.reconciler.intervalSeconds: "60" |
Member
There was a problem hiding this comment.
Do you mean this causes a corruption when you add a new line?
This was referenced Aug 31, 2024
[SPARK-49465] Fix example props override in helm chart operatorConfiguration.dynamicConfig.data
#114
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
[SPARK-49453] Add quotes for number in values.yaml
Why are the changes needed?
I have another value.yaml as below:
After running below with two values.yaml:
helm install spark-kubernetes-operator --create-namespace -f build-tools/helm/spark-kubernetes-operator/values.yaml -f tests/e2e/helm/dynamic-config-values.yaml build-tools/helm/spark-kubernetes-operator/
The generated configmap data field does not contains the line spark.kubernetes.operator.watchedNamespaces: "default, spark-1". Note that if you run helm install --dry-run, the record exist
Does this PR introduce any user-facing change?
no
How was this patch tested?
test locally
Was this patch authored or co-authored using generative AI tooling?
no