[SPARK-49465] Fix example props override in helm chart operatorConfiguration.dynamicConfig.data #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uration.dynamicConfig.data
dongjoon-hyun
pushed a commit
that referenced
this pull request
Aug 31, 2024
### What changes were proposed in this pull request? Add one more e2e test to validate the hot properties reload. ### Why are the changes needed? 1. It will verify Spark Operator reload the properties from dynamic config map 2. It will verify the watched namespace worked as expected ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Test from personal GitHub workflow Actions ### Was this patch authored or co-authored using generative AI tooling? no Closes #112, #114 Closes #115 from TQJADE/hot-properties-test. Authored-by: Qi Tan <qi_tan@apple.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Member
|
This is superceded by #115 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR updates example hot property override in values.yaml /
operatorConfiguration.dynamicConfig.data, make it including key value pairs of stringsWhy are the changes needed?
Does this PR introduce any user-facing change?
Number value in example may cause helm failure
Also, in fact Spark Operator consumes all property override as string values, it would parse the actual types accordingly.
How was this patch tested?
value parsing covered by existing CI, helm installation tested via minikube setup and custom value override
Was this patch authored or co-authored using generative AI tooling?
No