Skip to content

Comments

Use rogue instead of pygments.rb which is not Python 3 compatible#233

Merged
HyukjinKwon merged 1 commit intoapache:asf-sitefrom
HyukjinKwon:python3
Nov 22, 2019
Merged

Use rogue instead of pygments.rb which is not Python 3 compatible#233
HyukjinKwon merged 1 commit intoapache:asf-sitefrom
HyukjinKwon:python3

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Nov 22, 2019 •
edited
Loading

This PR make jekyll build independent of Python version by using rouge instead. See apache/spark#26521 for more details.

@HyukjinKwon HyukjinKwon requested review from dongjoon-hyun and srowen and removed request for dongjoon-hyun November 22, 2019 04:06
@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Nov 22, 2019

BTW, my local jekyll build before this PR makes no difference in the existing HTMLs:

➜  spark-website git:(asf-site) jekyll build
Configuration file: /.../spark-website/_config.yml
            Source: /.../spark-website
       Destination: site
 Incremental build: disabled. Enable with --incremental
      Generating...
                    done in 2.896 seconds.
 Auto-regeneration: disabled. Use --watch to enable.

➜  spark-website git:(asf-site) git status
On branch asf-site
Your branch is up to date with 'origin/asf-site'.

nothing to commit, working tree clean

So, this PR includes only the changes after this PR in HTMLs.

@HyukjinKwon HyukjinKwon merged commit 882e1e6 into apache:asf-site Nov 22, 2019
@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Nov 22, 2019

Merged. Thanks @srowen.

@dongjoon-hyun dongjoon-hyun mentioned this pull request Nov 26, 2019
Closed
srowen
srowen reviewed Nov 26, 2019
View reviewed changes
README.md

To install Jekyll and its required dependencies, execute `sudo gem install jekyll pygments.rb`
and `sudo pip install Pygments`.
To install Jekyll and its required dependencies, execute `sudo gem install jekyll rogue`.
Copy link
Member

@srowen srowen Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, it's rouge rather than rogue. Others are fixing it in the Docker image. I'll fix this.

Copy link
Member Author

@HyukjinKwon HyukjinKwon Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srowen srowen srowen approved these changes

@dongjoon-hyun dongjoon-hyun Awaiting requested review from dongjoon-hyun

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HyukjinKwon @srowen