-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-12396][Core]Once driver connect to a master successfully, stop it connect to master again. #10407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
ok to test |
|
Good catch, this change looks fine. |
|
Test build #48125 has finished for PR 10407 at commit
|
|
@echoTomei it's failing style tests because there's a whitespace at the end of the line |
|
@andrewor14 Sorry for my careless.I'll create another PR. |
…uccessfull. Delete the white space at the end of the line.
|
Test build #48151 has finished for PR 10407 at commit
|
|
@SparkQA The build error shows that the function cancel() is not a member of [java.util.concurrent.ScheduledFuture[_]] . I check the interface ScheduledFuture API ,confirming that this interface has cancel() function. So I don't understand why occur this error. Can you give me some suggestion?Thanks. |
|
retest this please |
|
Test build #48208 has finished for PR 10407 at commit
|
|
That is really confusing... @srowen do you know if we're missing something obvious? |
|
Actually the error says that the var is an Is this PR against a quite old version of master? while it doesn't technically need a rebase, it really does. |
|
I think a better approach is changing |
+1. Right now we call it both recursively and iteratively, which doesn't make sense... |
|
It seemed that change to registrationRetryThread.schedule is a better way. |
It is no need to register to master iteratively.
|
Could you rebase on the latest master? |
|
Test build #48231 has finished for PR 10407 at commit
|
|
Can you close this PR now that you've opened another one #10447 |
No description provided.