Skip to content

[STREAMING][DOCS][EXAMPLES] Minor fixes #10603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaceklaskowski wants to merge 3 commits into from
Closed

[STREAMING][DOCS][EXAMPLES] Minor fixes #10603

jaceklaskowski wants to merge 3 commits into from

Conversation

@jaceklaskowski
Copy link
Contributor

@jaceklaskowski jaceklaskowski commented Jan 5, 2016

No description provided.

srowen
srowen reviewed Jan 5, 2016
View reviewed changes
docs/streaming-custom-receivers.md Outdated
Copy link
Member

@srowen srowen Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was OK as-is; the rest looks OK. Again, can you batch together more changes? this is a lot of little PRs, and this has been discussed several times before

Copy link
Contributor Author

@jaceklaskowski jaceklaskowski Jan 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was discussed, but the changes are a result of my daily code reviews and I don't really know where I end up ahead. I'm now in Streaming so I will...batch...more changes next time.

@SparkQA
Copy link

SparkQA commented Jan 6, 2016

Test build #2333 has finished for PR 10603 at commit 07cdc9e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

rxin
rxin reviewed Jan 7, 2016
View reviewed changes
docs/streaming-custom-receivers.md Outdated
Copy link
Contributor

@rxin rxin Jan 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linking to current seem like a bad idea given they could have api breaking changes?

Copy link
Contributor Author

@jaceklaskowski jaceklaskowski Jan 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's about actors which are the fundamental concept of Akka so it's of less worry (like RDDs in Spark), but have changed it to the Akka version Spark uses, i.e. 2.3.11.

@rxin
Copy link
Contributor

rxin commented Jan 7, 2016

Other than that one line, rest LGTM.

@SparkQA
Copy link

SparkQA commented Jan 7, 2016

Test build #2344 has finished for PR 10603 at commit 7f215fc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@rxin
Copy link
Contributor

rxin commented Jan 7, 2016

I've merged this.

@asfgit asfgit closed this in 8113dbd Jan 7, 2016
@jaceklaskowski jaceklaskowski deleted the streaming-actor-custom-receiver branch January 7, 2016 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaceklaskowski @SparkQA @rxin @srowen