[SPARK-12659] fix NPE in UnsafeExternalSorter (used by cartesian product) #10606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
recordComparator is nullable? That's surprising to me. If recordComparator is null, does that also imply that prefixComparator is null? Can we put @Nullable annotations on the parameter so that IntelliJ's fancy nullability handling checks work properly?
|
Test build #48793 has finished for PR 10606 at commit
|
Contributor
Author
|
@JoshRosen I'm merging this into master and 1.6 branch to unblock another PR, will add @nullable in that PR. |
Contributor
|
More comments would also be appreciated, since this is pretty confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cartesian product use UnsafeExternalSorter without comparator to do spilling, it will NPE if spilling happens.
This bug also hitted by #10605
cc @JoshRosen